Create Task
Maniphest T5872

Make KPropertyUnit public or remove conversion to points in KProperty and KReport
Closed, ResolvedPublic
Actions

Description

( ) Make KPropertyUnit public because user needs conversion functions for units.
(*) Or remove conversion to points in KProperty and KReport so user won't care.

In the 1st case what's with KReportUnit? -- remove and reuse KPropertyUnit in KReport?

In the 2nd case - incompatible change compared to 3.0.

TODO:

  • Fix rounding errors and precision in the parents of composed propert (QSizeF on the screenshot):

  • Page margins get broken when user changes units

Details

Differential Revisions
D5419: Replace "unit" property option with "suffix"; add "prefix", support in double/integer/composed types

Related Objects

staniek created this task.Apr 12 2017, 7:01 PM
staniek updated the task description. (Show Details)Apr 13 2017, 9:23 AM
staniek claimed this task.
staniek added a comment.Apr 13 2017, 5:06 PM

Porting KReport

  • inspect all KProperty::setValue() and value() calls related to geometry
  • KReportUnit::parseValue() was used to parse XML and convert to pt.
staniek updated the task description. (Show Details)Apr 14 2017, 12:21 AM
staniek moved this task from TODO 3.2 to In Progress on the KProperty board.
staniek moved this task from Backlog to In Progress on the KReport board.
staniek updated the task description. (Show Details)Apr 14 2017, 12:24 AM
staniek closed this task as Resolved.Apr 27 2017, 10:00 PM