Clicking the pair request notification should open a dialog (KCM?) with buttons to accept/reject the pairing request.
Description
The notifications spec we use [1] says that clicking on a notification should trigger a "default" action. My idea was to use that action to display a message showing more info about the request and the Accept/Reject buttons. This should work even on desktop which don't support action buttons, or when the notifications hides in the Plasmoid (because the buttons disappear).
Unfortunately, this "default action" is not implemented either in the notifications plasmoid nor in KNotifications...
[1] https://people.gnome.org/~mccann/docs/notification-spec/notification-spec-latest.html
I see your point. Actually I wasn't aware that on certain desktops the action buttons disappear once the popup is gone because on my Plasma I still see them on the applet in the panel for persistent notifications.
Unless the optional "default" action is supported there might be no fix for the disappearing buttons other than using something else than notifications. But I guess that's not the way to go.
Maybe we can put it into the kdeconnect plasmoid, where we're free to do whatever we want. Like a new 'section' where we put pairing requests at the same time as the notif pops up and let it somehow pop up or highlight the kdeconnect-icon in the systray as is done for the notifications plasmoid once a persistent notification is added.
I also experimented with another KNotification that notifes about "Missed Pairing Request" and proposes a "Re-reqest Pairing" after the pairing notification was closed after timeout. But of course suffers the same issue that you mentioned.
I want to try to hack something into KNotifications for improving that :)
As a first step, can you push the fix that makes them persistent?
Done.
Cool, go ahead then!
BTW: Is there any documentation around about commit tags (like the previous "BUG:" for reviewtool) regarding phabricator?
BUG: isn't a reviewboard thing but a git.kde.org hook. Just keep using it as you're used to.
If you want it regarding actual Phabricator tasks (not bugzilla bugs) you can look at this link: https://secure.phabricator.com/T5132
Fixes Txxxx is possibly what you want.