Simplify create_tarball_kf5 by using kdoctools_install
Closed, ResolvedPublic

Description

If we use the kdoctools_install macro (defined in kdoctools/KF5DocToolsMacros.cmake), we can avoid to create all those CMakeLists.txt files in the doc subfolders. This would also be consistent with the ki18n_install macro usage.

This should go into a (non-yet existing) "kdesdk" or "kde-sdk-script" project, but we can handle it for now (minus pushing changes I guess, if the repository is not registered?).

Update: I changed the script so that now all *.docbook files go in po/<lang>/docs.
However, when I call kdoctools_install(po) from the root CMakeLists.txt, cmake fails with this error:

CMake Error at /usr/lib64/cmake/KF5DocTools/KF5DocToolsMacros.cmake:106 (message):
  SUBDIR needs to be defined when calling kdoctools_create_handbook

This happens with kdoctools 5.21. What's wrong?

ltoscano added a comment.EditedMay 9 2016, 1:44 PM

For handbooks, po/<lang>/docs/<name>/file.docbook
If you see, some repositories have more directories under doc already, see kleopatra; others have only one document and no subdirectories, but they need to be "normalized" as well.

Exception: man-*.docbook can go directly under po/<lang>/docs/

For handbooks, po/<lang>/docs/<name>/file.docbook
If you see, some repositories have more directories under doc already, see kleopatra; others have only one document and no subdirectories, but they need to be "normalized" as well.

Exception: man-*.docbook can go directly under po/<lang>/docs/

Oh I see. I guess then that the macro documentation in KF5DocToolsMacros.cmake should be updated to mention this?

elvisangelaccio closed this task as Resolved.May 31 2016, 4:54 PM
ltoscano moved this task from Backlog to Done on the Documentation board.Nov 10 2016, 11:32 PM