[RFC] Consider deprecating PlasmaExtras.PlasmoidHeading in favor of PC3.ToolBar
Open, HighPublic

Description

PlasmoidHeading is basically recreating ToolBar's API, so I think there's some merit in using that instead of PlasmoidHeading

This would basically involve styling ToolBar like PlasmoidHeading and doing a mass replace everywhere

The main benefits are:

  1. One less plasma specific component. We're using semantically appropriate components
  2. Migration should be relatively straightforward i.e. PlasmoidHeading -> ToolBar, PlasmoidHeading.Location ->ToolBar.position
  3. There shouldn't be any problem with back compat, since we don't use PC3 version of ToolBar *anywhere*.

There are few downsides as well:

  1. It's kind of weird having system tray mess with PC3 components, especially when they should have identical behavior to their QQC2 counterpart
  2. Negative inset/rounded corners. Kind of a deal breaker for in-content toolbar, although I'm not sure if that's a thing. Probably won't be an issue in KF6(?)
mikeljohnson renamed this task from [RFC] Consider deprecating PlasmaExtras.PlasmoidHeading with PC3.ToolBar to [RFC] Consider deprecating PlasmaExtras.PlasmoidHeading in favor of PC3.ToolBar.

I'm not sure this makes sense on a semantic level. The current PlasmoidHeading happens to be very similar to a toolbar, but is that always going to be the case? I don't want us to be locked into a situation where we can't change things later on because they would break other users of ToolBar or because the ToolBar API is not suitable any more

Good point, although we already have BasicPlasmoidHeading, which adds upon PlasmoidHeading

Presumably we wanna keep PlasmoidHeading as an appearance thing only, so I think replacing it makes sense, since if we wanna do more with it we can do a new component

sbmultimedia triaged this task as High priority.Dec 30 2021, 3:18 PM