Playing around some more, it seems to me that the exported data is structured as...

"some rating, either +, - or a number" "a space" "optionally a short text description of the rating"
"the optional text of the review itself"

It seems to me what should happen here is that the short description of the rating should go into the comment subject (which is currently unpopulated). I will update the task description with this in mind.

How's this coming along? :) (i can't finish up the work i'm doing in D21721 without this and T11173 being done)

Just a quick poke, because i kind of need this to happen... how's it coming along? Thanks in advance! I realise you've been ooo for a little bit :)

Please take a look at my changes.

Example output now:

<ocs>
  <meta>
    <status>ok</status>
    <statuscode>100</statuscode>
    <message/>
  </meta>
  <data>
    <comment>
      <id>1477913</id>
      <subject>the best</subject>
      <text>10 Thanks for sharing with the open community!</text>
      <childcount>0</childcount>
      <user>y27x</user>
      <date>2019-07-23T16:59:55+00:00</date>
      <score>100</score>
    </comment>
  </data>
  <data>
    <comment>
      <id>1473313</id>
      <subject>the best</subject>
      <text/>
      <childcount>0</childcount>
      <user>testmanifest</user>
      <date>2019-05-25T13:40:32+00:00</date>
      <score>100</score>
    </comment>
  </data>
  <data>
    <comment>
      <id>1472480</id>
      <subject>excellent</subject>
      <text/>
      <childcount>1</childcount>
      <user>jenspen</user>
      <date>2019-05-17T06:37:59+00:00</date>
      <score>90</score>
      <children>
        <comment>
          <id>1472576</id>
          <subject/>
          <text>thanks jenspen ;)</text>
          <childcount>0</childcount>
          <user>antechdesigns</user>
          <date>2019-05-18T10:11:45+00:00</date>
          <score>0</score>
        </comment>
      </children>
    </comment>
  </data>
...

That is so much better, thank you :D Works an absolute treat! Witness the now much nicer looking (though of course as yet somewhat unpolished) comments display in the shiny, new KNewStuffQuick components :)

Is there anything else to do from the server side?

I think we have a discrepancy between the comments being sent out via this call, and the number of comments reported in the content call. As an example, see below:

The comments shown in the dialog (ignore the Discover window) are those sent back by the server, but the number of comments the content call suggests is 28 (which incidentally is the correct number of /comments/, which is different to the reviews which we get here).

The comments call there is https://api.kde-look.org/ocs/v1/comments/data/1/1309269 - basically we'll want to ensure that the data returned by that call and the number suggested by content/data call https://api.kde-look.org/ocs/v1/content/data/1309269 match (so given where we're heading with reviews and whatnot, i'd say we'd want to simply have the number be the amount likely to be returned by comments/data, rather than changing what comments/data returns). Having the commentspage the way it is is fine, though, incidentally :)

Apart from that detail, though, it's good :)

Oh, I see. With /comment/data only comments with ratings are displayed at the moment. In /content/data however the number of all comments is displayed.
I will change the number of ratings/comments in the /content/data response.

Is that ok for you?

Hmm... In that case, if it's more like a filter, it might actually make sense to send all the comments out - how much trouble would it be to make it do so? (if it's a huge amount of work, then it's probably not really worth it, but i think it might well be good; it'd allow us to perhaps add some more interesting filtering and sorting options on the client side)

Well, so I'll return all comments in /comment/data in the future, even if not all of them contain a rating. You then have to ensure that the number of ratings is calculated correctly and displayed in the dialog. In your example, that would be 3 ratings/reviews for a total of 28 comments.

Great, i can work with that! :)

You should get now all comments.

Confirmed, thank you :) Need to do a bit of jiggery-pokery to the various consumers of the data, but it's already much more consistent now - always had a kind of "...what in the world?" feel when the numbers didn't match, and having this works well i think :) Thanks! Think we can call this one all done (if it turns out to need further work, we'd probably want to open a different ticket to track what and why for that, rather than this one)