Change Details

At the moment, the store considers comments a review, and because of this there is a rating included in the root comments' text in the OCS exported data. This is either a + or -, or an integer number from 0 through 10, which is then immediately followed by the text of the comment. What this means in practice is that it is somewhat awkward to interpret on the client side, and currently the result is that the comment is simply shown verbatim (that is, not interpreted in any way as a review score). That is to say, thiis is the case in Discover, but as KNewStuff currently doesn't support comments the issue is not shown there. What Discover does attempt to do is interpret the score value of the root comments as a review score (and it ignores any subcomments, though of course due to T11126 it currently never gets any anyway). The score at the moment is always 0, which makes the reviews look kind of sad in Discover's KNS support. So, proposals for resolving the various issues above in one go: * Don't export the review values in the comment text (which will make it look less strange). * Export - and + ratings as a score of 0 and 100 respectively * Export 0 through 10 ratings as 0 through 100 (that is, multiply the rating by ten, so it is the correct scale as suggested by the OCS spec) * Do nothing in Discover, which already expects the above situation (which will result in already released versions suddenly looking as it is supposed to) * Implement the same interpretation in the new comments support in KNewStuff nb: For completion, arguably it might have made sense to add a new field for review scores to comments, but the description in the OCS specification is vague on this topic and simply calls it a score, with no further descripton of what kind of score it is supposed to be. If we want to add in some kind of helpfulness score later (like on e.g. Steam, Amazon, and other places), then it would make sense for that to be the addition, rather than the review score which we need now, and which software already expects to exist.

At the moment, the store considers comments a review, and because of this there is a rating included in the root comments' text in the OCS exported data. This is either a + or -, or an integer number from 0 through 10, which is then immediately followed by the text of the comment. What this means in practice is that it is somewhat awkward to interpret on the client side, and currently the result is that the comment is simply shown verbatim (that is, not interpreted in any way as a review score). That is to say, thiis is the case in Discover, but as KNewStuff currently doesn't support comments the issue is not shown there. What Discover does attempt to do is interpret the score value of the root comments as a review score (and it ignores any subcomments, though of course due to T11126 it currently never gets any anyway). The score at the moment is always 0, which makes the reviews look kind of sad in Discover's KNS support. So, proposals for resolving the various issues above in one go: * Don't export the review values in the comment text (which will make it look less strange). * Export - and + ratings as a score of 1 and 100 respectively * Export 0 through 10 ratings as 1 through 100 (that is, multiply the rating by ten, so it is the correct scale as suggested by the OCS spec) * Interpret a score of 0 as "unrated" so clients can handle this in some sensible manner(1) * Do nothing in Discover, which already expects the above situation (which will result in already released versions suddenly looking as it is supposed to) * Implement the same interpretation in the new comments support in KNewStuff (1) If handled explicitly, it then be possible to do adjustments to the UI in some way (for example in KNewStuff we might want to hide a ratings display if there is no rating on a specific comment, for example a child comment), and if unhandled (such as in Discover) it will simply be interpreted as a rating of 0 without any adaptation (such as would be required if some number like -1 were to be considered the unrated number). nb: For completion, arguably it might have made sense to add a new field for review scores to comments, but the description in the OCS specification is vague on this topic and simply calls it a score, with no further descripton of what kind of score it is supposed to be. If we want to add in some kind of helpfulness score later (like on e.g. Steam, Amazon, and other places), then it would make sense for that to be the addition, rather than the review score which we need now, and which software already expects to exist.

At the moment, the store considers comments a review, and because of this there is a rating included in the root comments' text in the OCS exported data. This is either a + or -, or an integer number from 0 through 10, which is then immediately followed by the text of the comment. What this means in practice is that it is somewhat awkward to interpret on the client side, and currently the result is that the comment is simply shown verbatim (that is, not interpreted in any way as a review score). That is to say, thiis is the case in Discover, but as KNewStuff currently doesn't support comments the issue is not shown there. What Discover does attempt to do is interpret the score value of the root comments as a review score (and it ignores any subcomments, though of course due to T11126 it currently never gets any anyway). The score at the moment is always 0, which makes the reviews look kind of sad in Discover's KNS support. So, proposals for resolving the various issues above in one go: * Don't export the review values in the comment text (which will make it look less strange). * Export - and + ratings as a score of 0 and 100 respectively1 and 100 respectively * Export 0 through 10 ratings as 1 through 100 (that is, multiply the rating by ten, so it is the correct scale as suggested by the OCS spec) * Export 0 through 10 ratings as 0 through 100 (that is, multiply the rating by ten, so it is the correct scale as suggested by the OCS specInterpret a score of 0 as "unrated" so clients can handle this in some sensible manner(1) * Do nothing in Discover, which already expects the above situation (which will result in already released versions suddenly looking as it is supposed to) * Implement the same interpretation in the new comments support in KNewStuff (1) If handled explicitly, it then be possible to do adjustments to the UI in some way (for example in KNewStuff we might want to hide a ratings display if there is no rating on a specific comment, for example a child comment), and if unhandled (such as in Discover) it will simply be interpreted as a rating of 0 without any adaptation (such as would be required if some number like -1 were to be considered the unrated number). nb: For completion, arguably it might have made sense to add a new field for review scores to comments, but the description in the OCS specification is vague on this topic and simply calls it a score, with no further descripton of what kind of score it is supposed to be. If we want to add in some kind of helpfulness score later (like on e.g. Steam, Amazon, and other places), then it would make sense for that to be the addition, rather than the review score which we need now, and which software already expects to exist.