Remove gtkrc-2.0 legacy settings

Authored by gikari on Nov 7 2019, 5:55 PM.

Description

Remove gtkrc-2.0 legacy settings

Summary:
Previously GTK KCM wrote to gtkrc redundant settings lines:

  1. include "path to chosen gtk2 theme" #
style "user-font"
{
font-name="whatever font was chosen"
}
widget_style "*" style "user-font"

Now GTK KCM does not write those lines to configuration file,
but ones that was kept from previous versions of KCM
are causing various glitches, when applying gtk2
configuration, for theme and font configs respectively.

This patch fixes these issues removing these lines from gtkrc
by force, after applying any configuration from GTK KCM.

BUG: 413678

BUG: 413107

Test Plan:

  1. Open ~/gtkrc-2.0 and add those lines (theme and font name are arbitrary):
include "/usr/share/themes/Adwaita-dark/gtk-2.0/gtkrc"
style "user-font"
{
    font_name="Noto Sans Regular"
}
widget_class "*" style "user-font"
  1. Open GTK KCM and apply any configuration
  2. Reopen ~/gtkrc-2.0 file and check, that those lines were removed

Reviewers: cblack, Plasma, apol, ngraham

Reviewed By: cblack, ngraham

Subscribers: ervin, ngraham, plasma-devel

Tags: Plasma

Differential Revision: https://phabricator.kde.org/D25147

Details

Committed
ngrahamNov 7 2019, 5:55 PM
Reviewer
cblack
Differential Revision
D25147: Remove gtkrc-2.0 legacy settings
Parents
R99:cac399b1998c: Update version number for 5.17.2 GIT_SILENT
Branches
Unknown
Tags
Unknown