Convert shouldContinue check to boost::signal2
Description
Description
Details
Details
- Committed
mreeves Apr 19 2020, 3:41 PM - Parents
- R983:d9367f2ce944: Cleanup
- Branches
- Unknown
- Tags
| /CMakeLists.txt | ||
|---|---|---|
| 33 | Hi Michael. Which cmake version have you tested this with? The cmake versions used on KDE CI fail on this, not finding the component. Looking at my local cmake version 3.17.1 (which also matches the one used with openSUSE on CI, as I also use openSUSE) only checks "boost/signals.hpp" for headers, not signal2 ones. Same for what FreeBSD people reported. Cmp. https://build.kde.org/view/Failing/job/Extragear/job/kdiff3/ | |
| /CMakeLists.txt | ||
|---|---|---|
| 33 | Might it be the difference between FindBoost.cmake from cmake itself, and BoostConfig.cmake if you have Boost built with CMake support? I know we (FreeBSD) do not have a cmake-ified Boost yet. | |
Comment Actions
The windows build will should complete next time its run just update the craft blueprints.
| /CMakeLists.txt | ||
|---|---|---|
| 33 | Actually I think may be that I just happen to have boost:signal installed ans well as boost:signal2. So the check is wrong but seems to a work on my distro because they ship both. For the record I have cmake 3.13.4 on my machine and a docker image with cmake 3.10.2. Both it seems have boost:signal and therefor don't complain about this. Going to try find_package(Boost 1.66) . The version bump is because a couple of unrelated compile time bugs in boost 1.65. | |