Diffusion PIM: Message Library 9d3d9e1db83f

Fix clang warning about the ObjectTreeSourceIf vtable being emitted in every…
9d3d9e1db83f
Actions

Authored by dfaure on Apr 10 2016, 12:44 PM.

Description

Fix clang warning about the ObjectTreeSourceIf vtable being emitted in every translation unit.

Summary:
Pure interfaces don't get treated well by C++ compilers, better have a .cpp file for the dtor.
This required moving the header to one of the actual libs (viewer, since it's only used there).

Test Plan: Compiles

Reviewers: knauss, KDE PIM

Reviewed By: knauss, KDE PIM

Subscribers: knauss

Differential Revision: https://phabricator.kde.org/D1376

Details

Committed

dfaure

Apr 13 2016, 11:22 AM

Reviewer

KDE PIM

Differential Revision

D1376: Fix clang warning about the ObjectTreeSourceIf vtable being emitted in every translation unit.

Parents

R94:732ba12bd765: Fix clang warning about vtables being emitted in every translation unit.
R94:c45e776967ac: Prepare MessagePart to be used in Kube and mae it subclass of QObject.

Branches

Unknown

Tags

Unknown

dfaure committed R94:9d3d9e1db83f: Fix clang warning about the ObjectTreeSourceIf vtable being emitted in every… (authored by dfaure).Apr 13 2016, 11:22 AM

Merged Changes

	Commit			Author	Details	Committed
	732ba12bd765		D1376	dfaure	Fix clang warning about vtables being emitted in every translation unit.	Apr 13 2016

Changes (13)

				Path	Packages
	M			mimetreeparser/autotests/setupenv.h
	M			mimetreeparser/src/CMakeLists.txt
	P			mimetreeparser/src/interfaces/bodypart.cpp Copied from messageviewer/src/viewer/bodypartformatterfactorysingleton.h
	M			mimetreeparser/src/interfaces/bodypart.h
	P			mimetreeparser/src/interfaces/htmlwriter.cpp Copied from messageviewer/src/viewer/bodypartformatterfactorysingleton.h
	M			mimetreeparser/src/interfaces/htmlwriter.h
	P			mimetreeparser/src/interfaces/objecttreesourceif.cpp Copied from messagecomposer/src/composer/composerlineedit.h
	V			mimetreeparser/src/{interfaces ← }/objecttreesourceif.h
	V			mimetreeparser/src/{ → interfaces}/objecttreesourceif.h
	M			mimetreeparser/src/viewer/messagepart.cpp
	M			mimetreeparser/src/viewer/messagepart.h
	M			mimetreeparser/src/viewer/objecttreeparser.cpp
	M			mimetreeparser/src/viewer/objecttreeparser.h