Pure interfaces don't get treated well by C++ compilers, better have a .cpp file for the dtor.
This required moving the header to one of the actual libs (viewer, since it's only used there).
Details
Compiles
Diff Detail
- Repository
- R94 PIM: Message Library
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
This is probably not binary compatible though. But is that a problem already for this lib?
If you fix the issues feal free to push it.
mimetreeparser/autotests/setupenv.h | ||
---|---|---|
25 | please move it to interface subdir. This is the place it should go. | |
mimetreeparser/src/interfaces/objecttreesourceif.h | ||
49–50 | please move ctor as well to cpp | |
mimetreeparser/src/viewer/objecttreesourceif.cpp | ||
1 ↗ | (On Diff #3258) | remove the mode line as well |
23 ↗ | (On Diff #3258) | Code style: { } not in one line |
mimetreeparser/src/interfaces/objecttreesourceif.h | ||
---|---|---|
49–50 | Why the ctor? It's not necessary nor useful -- this is an interface so there should never be a member variable, right? The inline empty default ctor could also just be removed. I'm especially asking because I found 6 more classes with inline dtors so I'm fixing them all (and most of them only have a compiled-generated default-ctor)... |
mimetreeparser/src/interfaces/objecttreesourceif.cpp | ||
---|---|---|
24 | still a oneliner please change this to two lines like for other files. | |
mimetreeparser/src/interfaces/objecttreesourceif.h | ||
49–50 | yeah get rid of the unuseful ctor. | |
mimetreeparser/src/viewer/objecttreeparser.h | ||
61 | either #include or class ? both are not needed. if it works use the class forward declarion |
mimetreeparser/src/viewer/objecttreeparser.h | ||
---|---|---|
61 | oops yes my idea was to remove the unnecessary include, looks like I forgot. |
two small issues found - feel free to commit after fix these two.
mimetreeparser/src/CMakeLists.txt | ||
---|---|---|
122–123 | delete this line too - it is also not more available | |
mimetreeparser/src/viewer/objecttreeparser.h | ||
40 | in exported files it must be "mimetreeparser/objecttreesourceif.h" otherwise dependend packages like kde-addons won't find this include anymore |