Fix bad weak pointer usage
ac2868ad23b5
Actions

Authored by gladhorn on Nov 7 2016, 11:28 PM.

Description

Fix bad weak pointer usage

The assumption is that weak pointers can become null at any point in
time. Only dereference after converting to a strong pointer.

Details

Committed

gladhorn

Nov 7 2016, 11:42 PM

Parents

R37:fddc7d907878: Add toStrongRef to KisWeakPtr

Branches

Unknown

Tags

Unknown

Reverted By

R37:de3957a65b43: Partially revert "Fix bad weak pointer usage"

gladhorn committed R37:ac2868ad23b5: Fix bad weak pointer usage (authored by gladhorn).Nov 7 2016, 11:42 PM

Hi, @gladhorn!

What do you think if we introduce the following rules:

By default store a link to image or node as a strong pointer in your class.
If there is a hazard of a circular dependency or the class is stored in undo or GUI docker, store the link as a weak shared pointer.
Even if the class stores a weak pointer, methods should always return a strong pointer. Therefore, always convert a weak pointer into strong one before returning from a function.

What do you think about such rules? Do they look sane?

/libs/image/brushengine/kis_paintop_settings.cpp
80	I feel that it is better to use full class name here instead of auto. Our policy is not very strict about that: auto is fine, when using in for loops. Don't go overboard using it in other places. But I guess it is the case :)
/libs/image/kis_default_bounds.cpp
126	The same :)
/libs/image/kis_group_layer.cc
147	I think KisLayer::image() should return already converted KisImageSP. This is not a regression though, just a note.

gladhorn added a reverting change: R37:de3957a65b43: Partially revert "Fix bad weak pointer usage".Nov 8 2016, 10:17 PM

gladhorn mentioned this in R37:de3957a65b43: Partially revert "Fix bad weak pointer usage".

Changes (31)

				Path	Packages
	M			libs/image/brushengine/kis_paintop_settings.cpp
	M			libs/image/commands/kis_deselect_global_selection_command.cpp
	M			libs/image/commands/kis_image_change_layers_command.cpp
	M			libs/image/commands/kis_image_command.cpp
	M			libs/image/commands/kis_image_layer_add_command.cpp
	M			libs/image/commands/kis_image_layer_move_command.cpp
	M			libs/image/commands/kis_image_layer_remove_command.cpp
	M			libs/image/commands/kis_image_layer_remove_command_impl.cpp
	M			libs/image/commands/kis_image_lock_command.cpp
	M			libs/image/commands/kis_image_set_projection_color_space_command.cpp
	M			libs/image/commands/kis_node_property_list_command.cpp
	M			libs/image/commands/kis_reselect_global_selection_command.cpp
	M			libs/image/commands/kis_set_global_selection_command.cpp
	M			libs/image/commands_new/kis_change_projection_color_command.cpp
	M			libs/image/commands_new/kis_image_resize_command.cpp
	M			libs/image/commands_new/kis_image_set_resolution_command.cpp
	M			libs/image/kis_clone_layer.cpp
	M			libs/image/kis_colorspace_convert_visitor.cpp
	M			libs/image/kis_default_bounds.cpp
	M			libs/image/kis_group_layer.cc
	M			libs/image/kis_histogram.cc
	M			libs/image/kis_image_signal_router.cpp
	M			libs/image/kis_regenerate_frame_stroke_strategy.cpp
	M			libs/image/kis_selection_based_layer.cpp
	M			libs/image/kis_suspend_projection_updates_stroke_strategy.cpp
	M			plugins/extensions/colorspaceconversion/colorspaceconversion.cc
	M			plugins/extensions/imagesize/imagesize.cc
	M			plugins/extensions/layergroupswitcher/layergroupswitcher.cpp
	M			plugins/extensions/offsetimage/offsetimage.cpp
	M			plugins/extensions/separate_channels/kis_channel_separator.cc
	M			plugins/extensions/separate_channels/kis_separate_channels_plugin.cc