Diffusion Krita 200726964206

Opacity Keyframes Cache Correction -- Data-Race Correction
200726964206
Actions

Authored by eoinoneill on Mar 11 2020, 10:18 PM.

Description

Opacity Keyframes Cache Correction -- Data-Race Correction

Fixed Data-Race issue where DefaultBounds were incorrectly cloned when
cloning an image. This datarace caused undefined behavior that is now
corrected and helps with rendering Opacity Keyframes.

Added a new KisDefaultBoundsNodeWrapper class to handle bounds accessing
and checking inside of keyframe channels. This allows for easier copy
constructors for KisKeyframeChannels and helps keep data pointer logic
more consistent.

Now, when images are cloned, they are always pointing to the correct
time index.

Details

Committed

eoinoneill

Mar 20 2020, 4:43 AM

Parents

R37:12ca3f6656d0: Opacity Keyframes Cache Correction -- Affected Frames Correction

Branches

Unknown

Tags

Unknown

References

refs/merge-requests/264/head, refs/keep-around/2007269642067b388e4b2698afd8bf97b6727051

eoinoneill committed R37:200726964206: Opacity Keyframes Cache Correction -- Data-Race Correction (authored by eoinoneill).Mar 20 2020, 4:43 AM

rempt mentioned this in R37:4e45f39cce91: Opacity Keyframes Cache Correction -- Data-Race Correction.Apr 2 2020, 1:35 PM

Changes (21)

				Path	Packages
	M			libs/image/CMakeLists.txt
	M			libs/image/kis_base_node.cpp
	A			libs/image/kis_default_bounds_node_wrapper.cpp
	A			libs/image/kis_default_bounds_node_wrapper.h
	M			libs/image/kis_keyframe_channel.cpp
	M			libs/image/kis_keyframe_channel.h
	M			libs/image/kis_paint_device.cc
	M			libs/image/kis_raster_keyframe_channel.cpp
	M			libs/image/kis_raster_keyframe_channel.h
	M			libs/image/kis_scalar_keyframe_channel.cpp
	M			libs/image/kis_scalar_keyframe_channel.h
	M			libs/image/kis_transform_mask.cpp
	M			libs/image/kis_transform_mask_params_interface.h
	M			libs/ui/KisAsyncAnimationCacheRenderer.cpp
	M			libs/ui/dialogs/KisAsyncAnimationRenderDialogBase.cpp
	M			libs/ui/kis_animation_frame_cache.cpp
	M			libs/ui/tests/KisFrameCacheStoreTest.cpp
	M			plugins/tools/tool_transform2/kis_animated_transform_parameters.cpp
	M			plugins/tools/tool_transform2/kis_animated_transform_parameters.h
	M			plugins/tools/tool_transform2/kis_transform_args_keyframe_channel.cpp
	M			plugins/tools/tool_transform2/kis_transform_args_keyframe_channel.h

Opacity Keyframes Cache Correction -- Data-Race Correction200726964206Actions

Description

Details

Changes (21)

R37:200726964206

libs/image/CMakeLists.txt

libs/image/kis_base_node.cpp

libs/image/kis_default_bounds_node_wrapper.cpp

libs/image/kis_default_bounds_node_wrapper.h

libs/image/kis_keyframe_channel.cpp

libs/image/kis_keyframe_channel.h

libs/image/kis_paint_device.cc

libs/image/kis_raster_keyframe_channel.cpp

libs/image/kis_raster_keyframe_channel.h

libs/image/kis_scalar_keyframe_channel.cpp

libs/image/kis_scalar_keyframe_channel.h

libs/image/kis_transform_mask.cpp

libs/image/kis_transform_mask_params_interface.h

libs/ui/KisAsyncAnimationCacheRenderer.cpp

libs/ui/dialogs/KisAsyncAnimationRenderDialogBase.cpp

libs/ui/kis_animation_frame_cache.cpp

libs/ui/tests/KisFrameCacheStoreTest.cpp

plugins/tools/tool_transform2/kis_animated_transform_parameters.cpp

plugins/tools/tool_transform2/kis_animated_transform_parameters.h

plugins/tools/tool_transform2/kis_transform_args_keyframe_channel.cpp

plugins/tools/tool_transform2/kis_transform_args_keyframe_channel.h

Opacity Keyframes Cache Correction -- Data-Race Correction
200726964206
Actions