Optimize ArchiveModel::cleanFileName
Needs ReviewPublic

Authored by nicolasfella on Wed, Nov 27, 12:08 PM.

Details

Reviewers
None
Group Reviewers
Ark
Summary

Three string comparisons seem to be more efficient than the regular expression

Test Plan

Left is before, right is after. Note the red block on the left that isn't present on the right

Diff Detail

Repository
R36 Ark
Branch
cleanfilename
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19214
Build 19232: arc lint + arc unit
nicolasfella created this revision.Wed, Nov 27, 12:08 PM
Restricted Application added a project: Ark. · View Herald TranscriptWed, Nov 27, 12:08 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
nicolasfella requested review of this revision.Wed, Nov 27, 12:08 PM
nicolasfella edited the test plan for this revision. (Show Details)Wed, Nov 27, 12:09 PM

Interesting. How did you test this? Just opening an archive?

part/archivemodel.cpp
346

Why remove the debug line though?