Diffusion Ark 2c684ecd469f

Lazily load file entry icons

Authored by nicolasfella on Mar 14 2020, 4:23 PM.

Description

Lazily load file entry icons

Summary:
Building the icons datastructure is the most significant bottleneck when opening large archives. Knowing all the icons at loading time is unnecessary since most elements won't be visible anyway.
This patch moves the icon storing into the Entry class where it is lazily determined the first time it is accessed. This improves the initial archive loading time significantly.

Test Plan: It's hard to give exact numbers, but my main test archive (the Android NDK) went from ~3 seconds to load to "pretty much instant"

Reviewers: Ark, elvisangelaccio

Reviewed By: Ark, elvisangelaccio

Subscribers: broulik, kde-utils-devel

Tags: Ark

Differential Revision: https://phabricator.kde.org/D26357

Details

Committed
nicolasfellaMar 14 2020, 4:24 PM
Reviewer
Ark
Differential Revision
D26357: Lazily load file entry icons
Parents
R36:4dfbd053280a: Merge remote-tracking branch 'origin/release/19.12'
Branches
Unknown
Tags
Unknown