Building the icons datastructure is the most significant bottleneck when opening large archives. Knowing all the icons at loading time is unnecessary since most elements won't be visible anyway.
This patch moves the icon storing into the Entry class where it is lazily determined the first time it is accessed. This improves the initial archive loading time significantly.
Details
Details
- Reviewers
elvisangelaccio - Group Reviewers
Ark - Commits
- R36:2c684ecd469f: Lazily load file entry icons
It's hard to give exact numbers, but my main test archive (the Android NDK) went from ~3 seconds to load to "pretty much instant"
Diff Detail
Diff Detail
- Repository
- R36 Ark
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.