Refactor CliInterface
1074bf07a9b9
Actions

Authored by rthomsen on Nov 4 2016, 7:03 PM.

Description

Refactor CliInterface

CliInterface is refactored to be more simple. A new class CliProperties
is added which holds all the commands, switches and regex's for the cli
executables. Alot of code is moved from CliInterface to the new class.

Two new member variables are added to ReadOnlyArchiveInterface of types
QMimeType and KPluginMetaData. These are passed to CliProperties which
it uses to call ArchiveFormat::fromMetadata() so it can check archive
format properties.
The KPluginMetaData is passed from Archive to ReadOnlyArchiveInterface
as the second item in the args QVariantList.

CompressionMethods provided in the plugin json files was changed from a
QStringList to a QVariantMap so it can hold pairs of values: One user-
visible string and one value for the cli-switch.

Differential Revision: D3235

Details

Committed

rthomsen

Nov 4 2016, 7:03 PM

Differential Revision

D3235: CliInterface refactoring

Parents

R36:b01c0c21f23d: Fix minor typo

Branches

Unknown

Tags

Unknown

rthomsen committed R36:1074bf07a9b9: Refactor CliInterface (authored by rthomsen).Nov 4 2016, 7:03 PM

elvisangelaccio mentioned this in T2193: Cherry-pick fixes from Basyskom branch.Nov 5 2016, 11:04 AM

Changes (30)

				Path	Packages
	M			autotests/kerfuffle/jobstest.cpp
	M			autotests/plugins/cli7zplugin/cli7ztest.cpp
	M			autotests/plugins/clirarplugin/clirartest.cpp
	M			autotests/plugins/cliunarchiverplugin/cliunarchivertest.cpp
	M			autotests/plugins/clizipplugin/cliziptest.cpp
	M			autotests/plugins/clizipplugin/cliziptest.h
	M			kerfuffle/CMakeLists.txt
	M			kerfuffle/archive_kerfuffle.cpp
	M			kerfuffle/archive_kerfuffle.h
	M			kerfuffle/archiveformat.cpp
	M			kerfuffle/archiveformat.h
	M			kerfuffle/archiveinterface.cpp
	M			kerfuffle/archiveinterface.h
	M			kerfuffle/cliinterface.cpp
	M			kerfuffle/cliinterface.h
	A			kerfuffle/cliproperties.cpp
	A			kerfuffle/cliproperties.h
	M			kerfuffle/compressionoptionswidget.cpp
	M			plugins/cli7zplugin/cliplugin.cpp
	M			plugins/cli7zplugin/cliplugin.h
	M			plugins/cli7zplugin/kerfuffle_cli7z.json.cmake
	M			plugins/clirarplugin/cliplugin.cpp
	M			plugins/clirarplugin/cliplugin.h
	M			plugins/clirarplugin/kerfuffle_clirar.json.cmake
	M			plugins/cliunarchiverplugin/cliplugin.cpp
	M			plugins/cliunarchiverplugin/cliplugin.h
	M			plugins/cliunarchiverplugin/kerfuffle_cliunarchiver.json.cmake
	M			plugins/clizipplugin/cliplugin.cpp
	M			plugins/clizipplugin/cliplugin.h
	M			plugins/clizipplugin/kerfuffle_clizip.json.cmake

Refactor CliInterface1074bf07a9b9Actions

Description

Details

Changes (30)

R36:1074bf07a9b9

autotests/kerfuffle/jobstest.cpp

autotests/plugins/cli7zplugin/cli7ztest.cpp

autotests/plugins/clirarplugin/clirartest.cpp

autotests/plugins/cliunarchiverplugin/cliunarchivertest.cpp

autotests/plugins/clizipplugin/cliziptest.cpp

autotests/plugins/clizipplugin/cliziptest.h

kerfuffle/CMakeLists.txt

kerfuffle/archive_kerfuffle.cpp

kerfuffle/archive_kerfuffle.h

kerfuffle/archiveformat.cpp

kerfuffle/archiveformat.h

kerfuffle/archiveinterface.cpp

kerfuffle/archiveinterface.h

kerfuffle/cliinterface.cpp

kerfuffle/cliinterface.h

kerfuffle/cliproperties.cpp

kerfuffle/cliproperties.h

kerfuffle/compressionoptionswidget.cpp

plugins/cli7zplugin/cliplugin.cpp

plugins/cli7zplugin/cliplugin.h

plugins/cli7zplugin/kerfuffle_cli7z.json.cmake

plugins/clirarplugin/cliplugin.cpp

plugins/clirarplugin/cliplugin.h

plugins/clirarplugin/kerfuffle_clirar.json.cmake

plugins/cliunarchiverplugin/cliplugin.cpp

plugins/cliunarchiverplugin/cliplugin.h

plugins/cliunarchiverplugin/kerfuffle_cliunarchiver.json.cmake

plugins/clizipplugin/cliplugin.cpp

plugins/clizipplugin/cliplugin.h

plugins/clizipplugin/kerfuffle_clizip.json.cmake

Refactor CliInterface
1074bf07a9b9
Actions