Simplify url lookup in the ProjectChangesModel
Description
Description
Details
Details
- Committed
apol Jan 14 2016, 3:18 PM - Parents
- R33:b3de7de042f8: Prevent reloading the project changes twice
- Branches
- Unknown
- Tags
| /vcs/models/vcsfilechangesmodel.cpp | ||
|---|---|---|
| 162 | Why the check for column? This means index(0, 1).data(UrlRole) will return just the display string. Probably not what you want? | |
| /vcs/models/vcsfilechangesmodel.cpp | ||
|---|---|---|
| 162 | No, it will return the URL, note we're also checking the role. | |
| /vcs/models/vcsfilechangesmodel.cpp | ||
|---|---|---|
| 162 | I'm just confused why this check is needed, it shouldn't be needed. This whole QStandardItemModel::data overload could be trashed; since you already do the work in VcsStatusInfoItem::data, no? | |
| /vcs/models/vcsfilechangesmodel.cpp | ||
|---|---|---|
| 162 | No, because in some places we request the URL of the first column. Code can be adapted, but I rather have a predictable UrlRole for the whole row. | |