Allow to choose already created build directories when forcing to adopt one
Concern Raisedc2fdcb444caf
Actions

Authored by apol on Apr 25 2017, 3:57 PM.

Description

Allow to choose already created build directories when forcing to adopt one

So far we used to force the creation of a new one, which doesn't make sense
just because the current build directory is broken

Auditors

nalvarez

Committed

apol	Apr 25 2017, 3:57 PM

Parents

R32:7e2af7d8a7f7: Small cmakeutils refactoring

Branches

Unknown

Tags

Unknown

nalvarez raised a concern with this commit.Apr 28 2017, 12:10 AM

nalvarez added a subscriber: nalvarez.

nalvarez added inline comments.

/projectmanagers/cmake/cmakebuilddirchooser.cpp
69	QOverload is new in Qt 5.7. Either the requirement should be bumped in CMake, or this should be done with a plain old cast.

This commit now has outstanding concerns.Apr 28 2017, 12:10 AM

				Path	Packages
	M			projectmanagers/cmake/cmakebuilddirchooser.cpp
	M			projectmanagers/cmake/cmakebuilddirchooser.h
	M			projectmanagers/cmake/cmakebuilddirchooser.ui
	M			projectmanagers/cmake/cmakeutils.cpp
	M			projectmanagers/cmake/cmakeutils.h
	M			projectmanagers/cmake/settings/cmakepreferences.cpp