Do not resize new screen lines

Authored by mglb on Apr 3 2018, 7:33 PM.

Description

Do not resize new screen lines

Summary:
The lines are resized when something is put in them. Resizing them
here filled them with spaces (default value), later those trailing
spaces were put into history, and eventually into saved output or
clipboard (because it is assumed lines in history do not contain
trailing spaces).

BUG: 392419

Test Plan:

  • Enable "Trim trailing spaces" in Profile Settings → Mouse
  • Set window size to about 100x100px
  • Clear terminal (Ctrl-Shift-K by default)
  • Run:
seq $(( $(tput lines) * 2 )); \
printf '*** resize ***'; read -s; printf '\n'; \
seq $(( $(tput lines) * 2 ))
  • When "resize" show up, resize the window to about 500x500px
  • Press enter
  • Select and copy lines below *** resize ***
  • Paste it in a text editor which allows to show trailing spaces

Expected result: lines should not contain trailing spaces
Actual result: lines added when resizing the window have trailing spaces

Reviewers: Konsole, hindenburg

Reviewed By: Konsole, hindenburg

Subscribers: Konsole

Tags: Konsole

Differential Revision: https://phabricator.kde.org/D11893

Details

Committed
hindenburgApr 3 2018, 9:14 PM
Reviewer
Konsole
Differential Revision
D11893: Do not resize new screen lines
Parents
R319:a565bc97337a: Clip character drawing to its own cell
Branches
Unknown
Tags
Unknown