Process DBus replies in the ::match thread

Authored by davidedmundson on May 16 2018, 9:21 AM.

Description

Process DBus replies in the ::match thread

Summary:
6114612970bcf757d9e06a623d6220257ce57b5f turned the DBus requests into
using QDBusPendingCallWatcher but blocking so that it's still handled
within the ::match() method. However, it accidentally processed replies
in the main thread, rather than in the match thread which wasn't the
intention.

Result is occasional threading related crashes.

BUG: 394272

Test Plan:
Still had results from baloo (one of our DBus runners)
It didn't crash (but it never crashed for me before either)

One tester replied:
[10:00] ‎<‎sunnyflunk‎>‎ d_ed: looks good, tried 30 times with patch and no crash, then turned off the patch and crashed 4th time

Reviewers: Plasma, broulik

Reviewed By: Plasma, broulik

Subscribers: kde-frameworks-devel

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D12924

Details

Committed
davidedmundsonMay 16 2018, 9:21 AM
Reviewer
Plasma
Differential Revision
D12924: Process DBus replies in the ::match thread
Parents
R308:971f789f85db: GIT_SILENT Upgrade KF5 version to 5.47.0.
Branches
Unknown
Tags
Unknown