Diffusion GCompris ef598c387aaf

family: find_relatives: Repositioned tree and info
ef598c387aaf
Actions

Authored by rudranilbasu on Aug 6 2017, 10:00 PM.

Description

family: find_relatives: Repositioned tree and info

  • The "question" label is moved to the top-center of the screen
  • The borders of the treeArea and answer area is removed for expert mode, since there is only one section in this case
  • The treeArea is moved to the center of the activity for expert mode

Signed-off-by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

Details

Committed
rudranilbasuAug 6 2017, 10:00 PM
Parents
R2:de246e3ab463: family: randomised levels for "Family" activity
Branches
Unknown
Tags
Unknown
Restricted Application added a subscriber: jjazeix. ยท View Herald TranscriptAug 6 2017, 10:03 PM
jjazeix added inline comments.Aug 8 2017, 9:30 AM
/src/activities/family/Family.qml
171

normal/expert are not good names if it is to differentiate both activities, can we change it?

rudranilbasu added inline comments.Aug 8 2017, 6:26 PM
/src/activities/family/Family.qml
171

Renamed to the names of the activity, since they are not "modes" for a single activity,
rather they are two activities. So,

  • "normal" -> "family"
  • "expert" -> "find_relative"

Does this naming system look better?

Commit Link: https://cgit.kde.org/gcompris.git/commit/?id=59179780b07802a7ff3615db7c5944352aa3cf74

jjazeix added inline comments.Aug 8 2017, 7:55 PM
/src/activities/family/Family.qml
171

good for me :)

Changes (1)

PathPackages
Msrc/activities/family/Family.qml

R2:ef598c387aaf

View Options

src/activities/family/Family.qml

Loading...