Diffusion KMyMoney 96291539b3d0

Refactor wizards
96291539b3d0
Actions

Authored by wojnilowicz on Nov 19 2017, 9:46 AM.

Description

Refactor wizards

Patch aims mainly to speed up recompilation time through code
refactoring. Refactoring in this case means:

new syntax for signal-slot connections,
single class in single header,
d-pointers,
explicit constructors,
less interdependency in header files,
override keyword for virtual functions,
disabling copy constructors.

Differential Revision: https://phabricator.kde.org/D8926

Details

Committed

wojnilowicz

Nov 22 2017, 2:32 PM

Differential Revision

D8926: Refactor wizards

Parents

R261:64087f4573c4: Resolve compiler warnings

Branches

Unknown

Tags

Unknown

wojnilowicz committed R261:96291539b3d0: Refactor wizards (authored by wojnilowicz).Nov 22 2017, 2:32 PM

Changes (162)
Show All Changes

Very Large Commit

This commit is very large. Load each file individually.

				Path	Packages
	M			kmymoney/kmymoney.cpp
	M			kmymoney/widgets/CMakeLists.txt
	D			kmymoney/widgets/kmymoneywizard.cpp
	V			kmymoney/{widgets → wizards}/kmymoneywizard.h
	P			kmymoney/widgets/kmymoneywizard_p.h Deleted after being copied to multiple locations: kmymoney/wizards/kmymoneywizardpage_p.h kmymoney/wizards/newuserwizard/kaccountpage_p.h kmymoney/wizards/newuserwizard/kfilepage_p.h kmymoney/wizards/newuserwizard/kintropage.cpp kmymoney/wizards/newuserwizard/kpreferencepage.cpp kmymoney/wizards/newuserwizard/kpreferencepage_p.h kmymoney/wizards/wizardpage.h kmymoney/wizards/wizardpage_p.h
	V			kmymoney/{widgets → wizards}/kmymoneywizardpage.cpp
	V			kmymoney/{widgets → wizards}/kmymoneywizardpage.h
	M			kmymoney/wizards/CMakeLists.txt
	M			kmymoney/wizards/endingbalancedlg/CMakeLists.txt
	M			kmymoney/wizards/endingbalancedlg/checkingstartwizardpage.cpp
	M			kmymoney/wizards/endingbalancedlg/checkingstartwizardpage.h
	V			kmymoney/wizards/endingbalancedlg/{checkingstartwizardpage.ui ← checkingstartwizardpagedecl.ui}
	V			kmymoney/wizards/endingbalancedlg/{checkingstartwizardpagedecl.ui → checkingstartwizardpage.ui}
	M			kmymoney/wizards/endingbalancedlg/checkingstatementinfowizardpage.cpp
	M			kmymoney/wizards/endingbalancedlg/checkingstatementinfowizardpage.h
	V			kmymoney/wizards/endingbalancedlg/{checkingstatementinfowizardpage.ui ← checkingstatementinfowizardpagedecl.ui}
	V			kmymoney/wizards/endingbalancedlg/{checkingstatementinfowizardpagedecl.ui → checkingstatementinfowizardpage.ui}
	M			kmymoney/wizards/endingbalancedlg/interestchargecheckingswizardpage.cpp
	M			kmymoney/wizards/endingbalancedlg/interestchargecheckingswizardpage.h
	V			kmymoney/wizards/endingbalancedlg/{interestchargecheckingswizardpage.ui ← interestchargecheckingswizardpagedecl.ui}
	V			kmymoney/wizards/endingbalancedlg/{interestchargecheckingswizardpagedecl.ui → interestchargecheckingswizardpage.ui}
	M			kmymoney/wizards/endingbalancedlg/kendingbalancedlg.cpp
	M			kmymoney/wizards/endingbalancedlg/kendingbalancedlg.h
	V			kmymoney/wizards/endingbalancedlg/{kendingbalancedlg.ui ← kendingbalancedlgdecl.ui}
	V			kmymoney/wizards/endingbalancedlg/{kendingbalancedlgdecl.ui → kendingbalancedlg.ui}
	M			kmymoney/wizards/endingbalancedlg/previouspostponewizardpage.cpp
	M			kmymoney/wizards/endingbalancedlg/previouspostponewizardpage.h
	V			kmymoney/wizards/endingbalancedlg/{previouspostponewizardpage.ui ← previouspostponewizardpagedecl.ui}
	V			kmymoney/wizards/endingbalancedlg/{previouspostponewizardpagedecl.ui → previouspostponewizardpage.ui}
	A			kmymoney/wizards/kmymoneywizard.cpp
	V			kmymoney/{wizards ← widgets}/kmymoneywizard.h
	A			kmymoney/wizards/kmymoneywizard_p.h
	V			kmymoney/{wizards ← widgets}/kmymoneywizardpage.cpp
	V			kmymoney/{wizards ← widgets}/kmymoneywizardpage.h
	P			kmymoney/wizards/kmymoneywizardpage_p.h Copied from kmymoney/widgets/kmymoneywizard_p.h
	M			kmymoney/wizards/newaccountwizard/CMakeLists.txt
	A			kmymoney/wizards/newaccountwizard/hierarchyfilterproxymodel.cpp
	P			kmymoney/wizards/newaccountwizard/hierarchyfilterproxymodel.h Copied from kmymoney/wizards/wizardpages/userinfo.cpp
	A			kmymoney/wizards/newaccountwizard/kaccountsummarypage.cpp
	P			kmymoney/wizards/newaccountwizard/kaccountsummarypage.h Copied from kmymoney/wizards/wizardpages/userinfo.cpp
	V			kmymoney/wizards/newaccountwizard/{kaccountsummarypage.ui ← kaccountsummarypagedecl.ui}
	P			kmymoney/wizards/newaccountwizard/kaccountsummarypage_p.h Copied from kmymoney/wizards/wizardpages/userinfo.cpp
	V			kmymoney/wizards/newaccountwizard/{kaccountsummarypagedecl.ui → kaccountsummarypage.ui}
	A			kmymoney/wizards/newaccountwizard/kaccounttypepage.cpp
	A			kmymoney/wizards/newaccountwizard/kaccounttypepage.h
	V			kmymoney/wizards/newaccountwizard/{kaccounttypepage.ui ← kaccounttypepagedecl.ui}
	P			kmymoney/wizards/newaccountwizard/kaccounttypepage_p.h Copied from kmymoney/wizards/wizardpages/userinfo.cpp
	V			kmymoney/wizards/newaccountwizard/{kaccounttypepagedecl.ui → kaccounttypepage.ui}
	A			kmymoney/wizards/newaccountwizard/kbrokeragepage.cpp
	P			kmymoney/wizards/newaccountwizard/kbrokeragepage.h Copied from kmymoney/wizards/wizardpages/userinfo.cpp
	V			kmymoney/wizards/newaccountwizard/{kbrokeragepage.ui ← kbrokeragepagedecl.ui}
	P			kmymoney/wizards/newaccountwizard/kbrokeragepage_p.h Copied from kmymoney/wizards/wizardpages/userinfo.cpp
	V			kmymoney/wizards/newaccountwizard/{kbrokeragepagedecl.ui → kbrokeragepage.ui}
	A			kmymoney/wizards/newaccountwizard/kcreditcardschedulepage.cpp
	P			kmymoney/wizards/newaccountwizard/kcreditcardschedulepage.h Copied from kmymoney/wizards/wizardpages/userinfo.cpp
	V			kmymoney/wizards/newaccountwizard/{kcreditcardschedulepage.ui ← kschedulepagedecl.ui}
	P			kmymoney/wizards/newaccountwizard/kcreditcardschedulepage_p.h Copied from kmymoney/wizards/wizardpages/userinfo.cpp
	A			kmymoney/wizards/newaccountwizard/kgeneralloaninfopage.cpp
	P			kmymoney/wizards/newaccountwizard/kgeneralloaninfopage.h Copied from kmymoney/wizards/wizardpages/currency.cpp
	V			kmymoney/wizards/newaccountwizard/{kgeneralloaninfopage.ui ← kgeneralloaninfopagedecl.ui}
	P			kmymoney/wizards/newaccountwizard/kgeneralloaninfopage_p.h Copied from kmymoney/wizards/wizardpages/userinfo.cpp
	V			kmymoney/wizards/newaccountwizard/{kgeneralloaninfopagedecl.ui → kgeneralloaninfopage.ui}
	A			kmymoney/wizards/newaccountwizard/khierarchypage.cpp
	P			kmymoney/wizards/newaccountwizard/khierarchypage.h Copied from kmymoney/wizards/wizardpages/userinfo.cpp
	V			kmymoney/wizards/newaccountwizard/{khierarchypage.ui ← khierarchypagedecl.ui}
	P			kmymoney/wizards/newaccountwizard/khierarchypage_p.h Copied from kmymoney/wizards/wizardpages/userinfo.cpp
	V			kmymoney/wizards/newaccountwizard/{khierarchypagedecl.ui → khierarchypage.ui}
	A			kmymoney/wizards/newaccountwizard/kinstitutionpage.cpp
	P			kmymoney/wizards/newaccountwizard/kinstitutionpage.h Copied from kmymoney/wizards/wizardpages/currency.cpp
	V			kmymoney/wizards/newaccountwizard/{kinstitutionpage.ui ← kinstitutionpagedecl.ui}
	P			kmymoney/wizards/newaccountwizard/kinstitutionpage_p.h Copied from kmymoney/wizards/wizardpages/userinfo.cpp
	V			kmymoney/wizards/newaccountwizard/{kinstitutionpagedecl.ui → kinstitutionpage.ui}
	A			kmymoney/wizards/newaccountwizard/kloandetailspage.cpp
	A			kmymoney/wizards/newaccountwizard/kloandetailspage.h
	V			kmymoney/wizards/newaccountwizard/{kloandetailspage.ui ← kloandetailspagedecl.ui}
	P			kmymoney/wizards/newaccountwizard/kloandetailspage_p.h Copied from kmymoney/wizards/wizardpages/userinfo.cpp
	V			kmymoney/wizards/newaccountwizard/{kloandetailspagedecl.ui → kloandetailspage.ui}
	A			kmymoney/wizards/newaccountwizard/kloanpaymentpage.cpp
	A			kmymoney/wizards/newaccountwizard/kloanpaymentpage.h
	V			kmymoney/wizards/newaccountwizard/{kloanpaymentpage.ui ← kloanpaymentpagedecl.ui}
	P			kmymoney/wizards/newaccountwizard/kloanpaymentpage_p.h Copied from kmymoney/wizards/wizardpages/userinfo.cpp
	V			kmymoney/wizards/newaccountwizard/{kloanpaymentpagedecl.ui → kloanpaymentpage.ui}
	A			kmymoney/wizards/newaccountwizard/kloanpayoutpage.cpp
	P			kmymoney/wizards/newaccountwizard/kloanpayoutpage.h Copied from kmymoney/wizards/wizardpages/userinfo.cpp
	V			kmymoney/wizards/newaccountwizard/{kloanpayoutpage.ui ← kloanpayoutpagedecl.ui}
	P			kmymoney/wizards/newaccountwizard/kloanpayoutpage_p.h Copied from kmymoney/wizards/wizardpages/userinfo.cpp
	V			kmymoney/wizards/newaccountwizard/{kloanpayoutpagedecl.ui → kloanpayoutpage.ui}
	A			kmymoney/wizards/newaccountwizard/kloanschedulepage.cpp
	P			kmymoney/wizards/newaccountwizard/kloanschedulepage.h Copied from kmymoney/wizards/wizardpages/userinfo.cpp
	V			kmymoney/wizards/newaccountwizard/{kloanschedulepage.ui ← kloanschedulepagedecl.ui}
	P			kmymoney/wizards/newaccountwizard/kloanschedulepage_p.h Copied from kmymoney/wizards/wizardpages/userinfo.cpp
	V			kmymoney/wizards/newaccountwizard/{kloanschedulepagedecl.ui → kloanschedulepage.ui}
	M			kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp
	M			kmymoney/wizards/newaccountwizard/knewaccountwizard.h
	M			kmymoney/wizards/newaccountwizard/knewaccountwizard_p.h
	V			kmymoney/wizards/newaccountwizard/{kschedulepagedecl.ui → kcreditcardschedulepage.ui}
	M			kmymoney/wizards/newinvestmentwizard/kinvestmentdetailswizardpage.cpp
	M			kmymoney/wizards/newinvestmentwizard/knewinvestmentwizard.cpp
	M			kmymoney/wizards/newinvestmentwizard/knewinvestmentwizard.h
	M			kmymoney/wizards/newloanwizard/additionalfeeswizardpage.cpp
	M			kmymoney/wizards/newloanwizard/assetaccountwizardpage.cpp
	M			kmymoney/wizards/newloanwizard/effectivedatewizardpage.cpp
	M			kmymoney/wizards/newloanwizard/firstpaymentwizardpage.cpp
	M			kmymoney/wizards/newloanwizard/interestcategorywizardpage.cpp
	M			kmymoney/wizards/newloanwizard/interesteditwizardpage.cpp
	M			kmymoney/wizards/newloanwizard/knewloanwizard.cpp
	M			kmymoney/wizards/newloanwizard/loanamountwizardpage.cpp
	M			kmymoney/wizards/newloanwizard/loanattributeswizardpage.cpp
	M			kmymoney/wizards/newloanwizard/namewizardpage.cpp
	M			kmymoney/wizards/newloanwizard/paymenteditwizardpage.cpp
	M			kmymoney/wizards/newloanwizard/paymentfrequencywizardpage.cpp
	M			kmymoney/wizards/newloanwizard/schedulewizardpage.cpp
	M			kmymoney/wizards/newuserwizard/CMakeLists.txt
	A			kmymoney/wizards/newuserwizard/kaccountpage.cpp
	P			kmymoney/wizards/newuserwizard/kaccountpage.h Copied from kmymoney/wizards/wizardpages/currency.h
	V			kmymoney/wizards/newuserwizard/{kaccountpage.ui ← kaccountpagedecl.ui}
	P			kmymoney/wizards/newuserwizard/kaccountpage_p.h Copied from kmymoney/widgets/kmymoneywizard_p.h
	V			kmymoney/wizards/newuserwizard/{kaccountpagedecl.ui → kaccountpage.ui}
	A			kmymoney/wizards/newuserwizard/kcategoriespage.cpp
	P			kmymoney/wizards/newuserwizard/kcategoriespage.h Copied from kmymoney/wizards/wizardpages/accounts.h
	A			kmymoney/wizards/newuserwizard/kcurrencypage.cpp
	P			kmymoney/wizards/newuserwizard/kcurrencypage.h Copied from kmymoney/wizards/wizardpages/accounts.h
	V			kmymoney/wizards/newuserwizard/{kcurrencypage.ui ← kcurrencypagedecl.ui}
	V			kmymoney/wizards/newuserwizard/{kcurrencypagedecl.ui → kcurrencypage.ui}
	A			kmymoney/wizards/newuserwizard/kfilepage.cpp
	P			kmymoney/wizards/newuserwizard/kfilepage.h Copied from kmymoney/wizards/wizardpages/currency.h
	V			kmymoney/wizards/newuserwizard/{kfilepage.ui ← kfilepagedecl.ui}
	P			kmymoney/wizards/newuserwizard/kfilepage_p.h Copied from kmymoney/widgets/kmymoneywizard_p.h
	V			kmymoney/wizards/newuserwizard/{kfilepagedecl.ui → kfilepage.ui}
	A			kmymoney/wizards/newuserwizard/kgeneralpage.cpp
	P			kmymoney/wizards/newuserwizard/kgeneralpage.h Copied from kmymoney/wizards/wizardpages/accounts.h
	V			kmymoney/wizards/newuserwizard/{kgeneralpage.ui ← kgeneralpagedecl.ui}
	V			kmymoney/wizards/newuserwizard/{kgeneralpagedecl.ui → kgeneralpage.ui}
	P			kmymoney/wizards/newuserwizard/kintropage.cpp Copied from kmymoney/widgets/kmymoneywizard_p.h
	P			kmymoney/wizards/newuserwizard/kintropage.h Copied from kmymoney/wizards/wizardpages/currency.h
	V			kmymoney/wizards/newuserwizard/{kintropage.ui ← kintropagedecl.ui}
	V			kmymoney/wizards/newuserwizard/{kintropagedecl.ui → kintropage.ui}
	M			kmymoney/wizards/newuserwizard/knewuserwizard.cpp
	M			kmymoney/wizards/newuserwizard/knewuserwizard.h
	P			kmymoney/wizards/newuserwizard/knewuserwizard_p.h Copied from kmymoney/wizards/wizardpages/accounts.h
	V			kmymoney/wizards/newuserwizard/{kpasswordpage.ui ← kpasswordpagedecl.ui}
	V			kmymoney/wizards/newuserwizard/{kpasswordpagedecl.ui → kpasswordpage.ui}
	P			kmymoney/wizards/newuserwizard/kpreferencepage.cpp Copied from kmymoney/widgets/kmymoneywizard_p.h
	P			kmymoney/wizards/newuserwizard/kpreferencepage.h Copied from kmymoney/wizards/wizardpages/currency.h
	V			kmymoney/wizards/newuserwizard/{kpreferencepage.ui ← kpreferencepagedecl.ui}
	P			kmymoney/wizards/newuserwizard/kpreferencepage_p.h Copied from kmymoney/widgets/kmymoneywizard_p.h
	V			kmymoney/wizards/newuserwizard/{kpreferencepagedecl.ui → kpreferencepage.ui}
	P			kmymoney/wizards/wizardpage.h Copied from kmymoney/widgets/kmymoneywizard_p.h
	V			kmymoney/{wizards/wizardpage_p.h ← widgets/kmymoneywizard_p.h}
	M			kmymoney/wizards/wizardpages/CMakeLists.txt
	M			kmymoney/wizards/wizardpages/accounts.cpp
	P			kmymoney/wizards/wizardpages/accounts.h Copied to multiple locations: kmymoney/wizards/newuserwizard/kcategoriespage.h kmymoney/wizards/newuserwizard/kcurrencypage.h kmymoney/wizards/newuserwizard/kgeneralpage.h kmymoney/wizards/newuserwizard/knewuserwizard_p.h
	V			kmymoney/wizards/wizardpages/{accounts.ui ← accountsdecl.ui}
	V			kmymoney/wizards/wizardpages/{accountsdecl.ui → accounts.ui}
	P			kmymoney/wizards/wizardpages/currency.cpp Copied to multiple locations: kmymoney/wizards/newaccountwizard/kgeneralloaninfopage.h kmymoney/wizards/newaccountwizard/kinstitutionpage.h
	P			kmymoney/wizards/wizardpages/currency.h Copied to multiple locations: kmymoney/wizards/newuserwizard/kaccountpage.h kmymoney/wizards/newuserwizard/kfilepage.h kmymoney/wizards/newuserwizard/kintropage.h kmymoney/wizards/newuserwizard/kpreferencepage.h
	V			kmymoney/wizards/wizardpages/{currency.ui ← currencydecl.ui}
	V			kmymoney/wizards/wizardpages/{currencydecl.ui → currency.ui}
	P			kmymoney/wizards/wizardpages/userinfo.cpp Copied to multiple locations: kmymoney/wizards/newaccountwizard/hierarchyfilterproxymodel.h kmymoney/wizards/newaccountwizard/kaccountsummarypage.h kmymoney/wizards/newaccountwizard/kaccountsummarypage_p.h kmymoney/wizards/newaccountwizard/kaccounttypepage_p.h kmymoney/wizards/newaccountwizard/kbrokeragepage.h kmymoney/wizards/newaccountwizard/kbrokeragepage_p.h kmymoney/wizards/newaccountwizard/kcreditcardschedulepage.h kmymoney/wizards/newaccountwizard/kcreditcardschedulepage_p.h kmymoney/wizards/newaccountwizard/kgeneralloaninfopage_p.h kmymoney/wizards/newaccountwizard/khierarchypage.h kmymoney/wizards/newaccountwizard/khierarchypage_p.h kmymoney/wizards/newaccountwizard/kinstitutionpage_p.h kmymoney/wizards/newaccountwizard/kloandetailspage_p.h kmymoney/wizards/newaccountwizard/kloanpaymentpage_p.h kmymoney/wizards/newaccountwizard/kloanpayoutpage.h kmymoney/wizards/newaccountwizard/kloanpayoutpage_p.h kmymoney/wizards/newaccountwizard/kloanschedulepage.h kmymoney/wizards/newaccountwizard/kloanschedulepage_p.h
	M			kmymoney/wizards/wizardpages/userinfo.h
	V			kmymoney/wizards/wizardpages/{userinfo.ui ← userinfodecl.ui}
	V			kmymoney/wizards/wizardpages/{userinfodecl.ui → userinfo.ui}