Differential D8926

Refactor wizards
ClosedPublic
Actions

Authored by wojnilowicz on Nov 21 2017, 4:25 PM.

Details

Reviewers

tbaumgart

Group Reviewers

KMyMoney

Commits

R261:96291539b3d0: Refactor wizards

Summary

Patch aims mainly to speed up recompilation time through code
refactoring. Refactoring in this case means:

new syntax for signal-slot connections,
single class in single header,
d-pointers,
explicit constructors,
less interdependency in header files,
override keyword for virtual functions,
disabling copy constructors.

Test Plan

Created new user and new loan account.

Diff Detail

Repository

R261 KMyMoney

Lint

Lint Skipped

Unit

Unit Tests Skipped

wojnilowicz created this revision.Nov 21 2017, 4:25 PM

Looks good to me and compiles. Generates a bunch of warnings, but I can take care of them once it is in the git repo

This revision is now accepted and ready to land.Nov 22 2017, 10:03 AM

wojnilowicz closed this revision.Nov 22 2017, 2:33 PM

Large Diff

This large diff affects 162 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

		Path
M		kmymoney/kmymoney.cpp (3 lines)
M		kmymoney/widgets/CMakeLists.txt (4 lines)
V		kmymoney/{widgets → wizards}/kmymoneywizard.h
D	M	kmymoney/widgets/kmymoneywizard.cpp (339 lines)
V		kmymoney/{widgets/kmymoneywizard_p.h → wizards/kmymoneywizardpage_p.h}
V		kmymoney/{widgets → wizards}/kmymoneywizardpage.h
V		kmymoney/{widgets → wizards}/kmymoneywizardpage.cpp
M		kmymoney/wizards/CMakeLists.txt (9 lines)
M		kmymoney/wizards/endingbalancedlg/CMakeLists.txt (10 lines)
M		kmymoney/wizards/endingbalancedlg/checkingstartwizardpage.h (18 lines)
M		kmymoney/wizards/endingbalancedlg/checkingstartwizardpage.cpp (14 lines)
V		kmymoney/wizards/endingbalancedlg/{checkingstartwizardpage.ui ← checkingstartwizardpagedecl.ui} (4 lines)
V		kmymoney/wizards/endingbalancedlg/{checkingstartwizardpagedecl.ui → checkingstartwizardpage.ui}
M		kmymoney/wizards/endingbalancedlg/checkingstatementinfowizardpage.h (17 lines)
M		kmymoney/wizards/endingbalancedlg/checkingstatementinfowizardpage.cpp (26 lines)
V		kmymoney/wizards/endingbalancedlg/{checkingstatementinfowizardpage.ui ← checkingstatementinfowizardpagedecl.ui} (4 lines)
V		kmymoney/wizards/endingbalancedlg/{checkingstatementinfowizardpagedecl.ui → checkingstatementinfowizardpage.ui}
M		kmymoney/wizards/endingbalancedlg/interestchargecheckingswizardpage.h (17 lines)
M		kmymoney/wizards/endingbalancedlg/interestchargecheckingswizardpage.cpp (46 lines)
V		kmymoney/wizards/endingbalancedlg/{interestchargecheckingswizardpage.ui ← interestchargecheckingswizardpagedecl.ui} (4 lines)
V		kmymoney/wizards/endingbalancedlg/{interestchargecheckingswizardpagedecl.ui → interestchargecheckingswizardpage.ui}
M		kmymoney/wizards/endingbalancedlg/kendingbalancedlg.h (40 lines)
M		kmymoney/wizards/endingbalancedlg/kendingbalancedlg.cpp (100 lines)
V		kmymoney/wizards/endingbalancedlg/{kendingbalancedlg.ui ← kendingbalancedlgdecl.ui} (4 lines)
V		kmymoney/wizards/endingbalancedlg/{kendingbalancedlgdecl.ui → kendingbalancedlg.ui}
M		kmymoney/wizards/endingbalancedlg/previouspostponewizardpage.h (17 lines)
M		kmymoney/wizards/endingbalancedlg/previouspostponewizardpage.cpp (15 lines)
V		kmymoney/wizards/endingbalancedlg/{previouspostponewizardpage.ui ← previouspostponewizardpagedecl.ui} (4 lines)
V		kmymoney/wizards/endingbalancedlg/{previouspostponewizardpagedecl.ui → previouspostponewizardpage.ui}
V		kmymoney/{wizards ← widgets}/kmymoneywizard.h (81 lines)
A	M	kmymoney/wizards/kmymoneywizard.cpp (184 lines)
A	M	kmymoney/wizards/kmymoneywizard_p.h (320 lines)
V		kmymoney/{wizards ← widgets}/kmymoneywizardpage.h (50 lines)
V		kmymoney/{wizards ← widgets}/kmymoneywizardpage.cpp (51 lines)
V		kmymoney/{wizards/kmymoneywizardpage_p.h ← widgets/kmymoneywizard_p.h} (36 lines)
M		kmymoney/wizards/newaccountwizard/CMakeLists.txt (24 lines)
A	M	kmymoney/wizards/newaccountwizard/hierarchyfilterproxymodel.h (52 lines)
A	M	kmymoney/wizards/newaccountwizard/hierarchyfilterproxymodel.cpp (65 lines)
A	M	kmymoney/wizards/newaccountwizard/kaccountsummarypage.h (57 lines)
A	M	kmymoney/wizards/newaccountwizard/kaccountsummarypage.cpp (229 lines)
V		kmymoney/wizards/newaccountwizard/{kaccountsummarypage.ui ← kaccountsummarypagedecl.ui} (4 lines)
A	M	kmymoney/wizards/newaccountwizard/kaccountsummarypage_p.h (59 lines)
V		kmymoney/wizards/newaccountwizard/{kaccountsummarypagedecl.ui → kaccountsummarypage.ui}
A	M	kmymoney/wizards/newaccountwizard/kaccounttypepage.h (86 lines)
A	M	kmymoney/wizards/newaccountwizard/kaccounttypepage.cpp (271 lines)
V		kmymoney/wizards/newaccountwizard/{kaccounttypepage.ui ← kaccounttypepagedecl.ui} (4 lines)
A	M	kmymoney/wizards/newaccountwizard/kaccounttypepage_p.h (60 lines)
V		kmymoney/wizards/newaccountwizard/{kaccounttypepagedecl.ui → kaccounttypepage.ui}
A	M	kmymoney/wizards/newaccountwizard/kbrokeragepage.h (63 lines)
A	M	kmymoney/wizards/newaccountwizard/kbrokeragepage.cpp (100 lines)
V		kmymoney/wizards/newaccountwizard/{kbrokeragepage.ui ← kbrokeragepagedecl.ui} (4 lines)
A	M	kmymoney/wizards/newaccountwizard/kbrokeragepage_p.h (59 lines)
V		kmymoney/wizards/newaccountwizard/{kbrokeragepagedecl.ui → kbrokeragepage.ui}
A	M	kmymoney/wizards/newaccountwizard/kcreditcardschedulepage.h (65 lines)
A	M	kmymoney/wizards/newaccountwizard/kcreditcardschedulepage.cpp (161 lines)
V		kmymoney/wizards/newaccountwizard/{kcreditcardschedulepage.ui ← kschedulepagedecl.ui} (4 lines)
A	M	kmymoney/wizards/newaccountwizard/kcreditcardschedulepage_p.h (59 lines)
A	M	kmymoney/wizards/newaccountwizard/kgeneralloaninfopage.h (75 lines)
A	M	kmymoney/wizards/newaccountwizard/kgeneralloaninfopage.cpp (175 lines)
V		kmymoney/wizards/newaccountwizard/{kgeneralloaninfopage.ui ← kgeneralloaninfopagedecl.ui} (4 lines)
A	M	kmymoney/wizards/newaccountwizard/kgeneralloaninfopage_p.h (60 lines)
V		kmymoney/wizards/newaccountwizard/{kgeneralloaninfopagedecl.ui → kgeneralloaninfopage.ui}
A	M	kmymoney/wizards/newaccountwizard/khierarchypage.h (69 lines)
A	M	kmymoney/wizards/newaccountwizard/khierarchypage.cpp (127 lines)
V		kmymoney/wizards/newaccountwizard/{khierarchypage.ui ← khierarchypagedecl.ui} (4 lines)
A	M	kmymoney/wizards/newaccountwizard/khierarchypage_p.h (63 lines)
V		kmymoney/wizards/newaccountwizard/{khierarchypagedecl.ui → khierarchypage.ui}
A	M	kmymoney/wizards/newaccountwizard/kinstitutionpage.h (75 lines)
A	M	kmymoney/wizards/newaccountwizard/kinstitutionpage.cpp (147 lines)
V		kmymoney/wizards/newaccountwizard/{kinstitutionpage.ui ← kinstitutionpagedecl.ui} (4 lines)
A	M	kmymoney/wizards/newaccountwizard/kinstitutionpage_p.h (61 lines)
V		kmymoney/wizards/newaccountwizard/{kinstitutionpagedecl.ui → kinstitutionpage.ui}
A	M	kmymoney/wizards/newaccountwizard/kloandetailspage.h (80 lines)
A	M	kmymoney/wizards/newaccountwizard/kloandetailspage.cpp (424 lines)
V		kmymoney/wizards/newaccountwizard/{kloandetailspage.ui ← kloandetailspagedecl.ui} (4 lines)
A	M	kmymoney/wizards/newaccountwizard/kloandetailspage_p.h (60 lines)
V		kmymoney/wizards/newaccountwizard/{kloandetailspagedecl.ui → kloandetailspage.ui}
A	M	kmymoney/wizards/newaccountwizard/kloanpaymentpage.h (85 lines)
A	M	kmymoney/wizards/newaccountwizard/kloanpaymentpage.cpp (152 lines)
V		kmymoney/wizards/newaccountwizard/{kloanpaymentpage.ui ← kloanpaymentpagedecl.ui} (4 lines)
A	M	kmymoney/wizards/newaccountwizard/kloanpaymentpage_p.h (67 lines)
V		kmymoney/wizards/newaccountwizard/{kloanpaymentpagedecl.ui → kloanpaymentpage.ui}
A	M	kmymoney/wizards/newaccountwizard/kloanpayoutpage.h (69 lines)
A	M	kmymoney/wizards/newaccountwizard/kloanpayoutpage.cpp (173 lines)
V		kmymoney/wizards/newaccountwizard/{kloanpayoutpage.ui ← kloanpayoutpagedecl.ui} (4 lines)
A	M	kmymoney/wizards/newaccountwizard/kloanpayoutpage_p.h (59 lines)
V		kmymoney/wizards/newaccountwizard/{kloanpayoutpagedecl.ui → kloanpayoutpage.ui}
A	M	kmymoney/wizards/newaccountwizard/kloanschedulepage.h (72 lines)
A	M	kmymoney/wizards/newaccountwizard/kloanschedulepage.cpp (142 lines)
V		kmymoney/wizards/newaccountwizard/{kloanschedulepage.ui ← kloanschedulepagedecl.ui} (4 lines)
A	M	kmymoney/wizards/newaccountwizard/kloanschedulepage_p.h (59 lines)
V		kmymoney/wizards/newaccountwizard/{kloanschedulepagedecl.ui → kloanschedulepage.ui}
M		kmymoney/wizards/newaccountwizard/knewaccountwizard.h (156 lines)
M		kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp (1888 lines)
M		kmymoney/wizards/newaccountwizard/knewaccountwizard_p.h (481 lines)
V		kmymoney/wizards/newaccountwizard/{kschedulepagedecl.ui → kcreditcardschedulepage.ui}
M		kmymoney/wizards/newinvestmentwizard/kinvestmentdetailswizardpage.cpp (2 lines)
M		kmymoney/wizards/newinvestmentwizard/knewinvestmentwizard.h (6 lines)
M		kmymoney/wizards/newinvestmentwizard/knewinvestmentwizard.cpp (2 lines)
M		kmymoney/wizards/newloanwizard/additionalfeeswizardpage.cpp (2 lines)
M		kmymoney/wizards/newloanwizard/assetaccountwizardpage.cpp (6 lines)
M		kmymoney/wizards/newloanwizard/effectivedatewizardpage.cpp (2 lines)
M		kmymoney/wizards/newloanwizard/firstpaymentwizardpage.cpp (2 lines)
M		kmymoney/wizards/newloanwizard/interestcategorywizardpage.cpp (4 lines)
M		kmymoney/wizards/newloanwizard/interesteditwizardpage.cpp (2 lines)
M		kmymoney/wizards/newloanwizard/knewloanwizard.cpp (3 lines)
M		kmymoney/wizards/newloanwizard/loanamountwizardpage.cpp (2 lines)
M		kmymoney/wizards/newloanwizard/loanattributeswizardpage.cpp (4 lines)
M		kmymoney/wizards/newloanwizard/namewizardpage.cpp (2 lines)
M		kmymoney/wizards/newloanwizard/paymenteditwizardpage.cpp (2 lines)
M		kmymoney/wizards/newloanwizard/paymentfrequencywizardpage.cpp (3 lines)
M		kmymoney/wizards/newloanwizard/schedulewizardpage.cpp (4 lines)
M		kmymoney/wizards/newuserwizard/CMakeLists.txt (16 lines)
A	M	kmymoney/wizards/newuserwizard/kaccountpage.h (61 lines)
A	M	kmymoney/wizards/newuserwizard/kaccountpage.cpp (75 lines)
V		kmymoney/wizards/newuserwizard/{kaccountpage.ui ← kaccountpagedecl.ui} (4 lines)
A	M	kmymoney/wizards/newuserwizard/kaccountpage_p.h (57 lines)
V		kmymoney/wizards/newuserwizard/{kaccountpagedecl.ui → kaccountpage.ui}
A	M	kmymoney/wizards/newuserwizard/kcategoriespage.h (62 lines)
A	M	kmymoney/wizards/newuserwizard/kcategoriespage.cpp (75 lines)
A	M	kmymoney/wizards/newuserwizard/kcurrencypage.h (59 lines)
A	M	kmymoney/wizards/newuserwizard/kcurrencypage.cpp (126 lines)
V		kmymoney/wizards/newuserwizard/{kcurrencypage.ui ← kcurrencypagedecl.ui} (4 lines)
V		kmymoney/wizards/newuserwizard/{kcurrencypagedecl.ui → kcurrencypage.ui}
A	M	kmymoney/wizards/newuserwizard/kfilepage.h (58 lines)
A	M	kmymoney/wizards/newuserwizard/kfilepage.cpp (104 lines)
V		kmymoney/wizards/newuserwizard/{kfilepage.ui ← kfilepagedecl.ui} (4 lines)
A	M	kmymoney/wizards/newuserwizard/kfilepage_p.h (57 lines)
V		kmymoney/wizards/newuserwizard/{kfilepagedecl.ui → kfilepage.ui}
A	M	kmymoney/wizards/newuserwizard/kgeneralpage.h (63 lines)
A	M	kmymoney/wizards/newuserwizard/kgeneralpage.cpp (114 lines)
V		kmymoney/wizards/newuserwizard/{kgeneralpage.ui ← kgeneralpagedecl.ui} (4 lines)
V		kmymoney/wizards/newuserwizard/{kgeneralpagedecl.ui → kgeneralpage.ui}
A	M	kmymoney/wizards/newuserwizard/kintropage.h (55 lines)
A	M	kmymoney/wizards/newuserwizard/kintropage.cpp (77 lines)
V		kmymoney/wizards/newuserwizard/{kintropage.ui ← kintropagedecl.ui} (4 lines)
V		kmymoney/wizards/newuserwizard/{kintropagedecl.ui → kintropage.ui}
M		kmymoney/wizards/newuserwizard/knewuserwizard.h (89 lines)
M		kmymoney/wizards/newuserwizard/knewuserwizard.cpp (401 lines)
M		kmymoney/wizards/newuserwizard/knewuserwizard_p.h (182 lines)
V		kmymoney/wizards/newuserwizard/{kpasswordpage.ui ← kpasswordpagedecl.ui} (4 lines)
V		kmymoney/wizards/newuserwizard/{kpasswordpagedecl.ui → kpasswordpage.ui}
A	M	kmymoney/wizards/newuserwizard/kpreferencepage.h (60 lines)
A	M	kmymoney/wizards/newuserwizard/kpreferencepage.cpp (57 lines)
V		kmymoney/wizards/newuserwizard/{kpreferencepage.ui ← kpreferencepagedecl.ui} (4 lines)
A	M	kmymoney/wizards/newuserwizard/kpreferencepage_p.h (56 lines)
V		kmymoney/wizards/newuserwizard/{kpreferencepagedecl.ui → kpreferencepage.ui}
A	M	kmymoney/wizards/wizardpage.h (75 lines)
A	M	kmymoney/wizards/wizardpage_p.h (47 lines)
M		kmymoney/wizards/wizardpages/CMakeLists.txt (4 lines)
M		kmymoney/wizards/wizardpages/accounts.h (21 lines)
M		kmymoney/wizards/wizardpages/accounts.cpp (11 lines)
V		kmymoney/wizards/wizardpages/{accounts.ui ← accountsdecl.ui} (4 lines)
V		kmymoney/wizards/wizardpages/{accountsdecl.ui → accounts.ui}
M		kmymoney/wizards/wizardpages/currency.h (23 lines)
M		kmymoney/wizards/wizardpages/currency.cpp (25 lines)
V		kmymoney/wizards/wizardpages/{currency.ui ← currencydecl.ui} (4 lines)
V		kmymoney/wizards/wizardpages/{currencydecl.ui → currency.ui}
M		kmymoney/wizards/wizardpages/userinfo.h (23 lines)
M		kmymoney/wizards/wizardpages/userinfo.cpp (27 lines)
V		kmymoney/wizards/wizardpages/{userinfo.ui ← userinfodecl.ui} (4 lines)
V		kmymoney/wizards/wizardpages/{userinfodecl.ui → userinfo.ui}