Refactor widgets
802c8f4b98b0
Actions

Authored by wojnilowicz on Nov 12 2017, 2:03 PM.

Description

Refactor widgets

Patch aims mainly to speed up recompilation time through code
refactoring. Refactoring in this case means:

new syntax for signal-slot connections,
enums in separate header file,
single class in single header,
d-pointers,
single inheritance for widget classes,
explicit constructors,
less interdependency in header files,
override keyword for virtual functions,
disabling copy constructors,
rename kMyMoney* to KMymoney* to be consistent.

Differential Revision: https://phabricator.kde.org/D8878

Details

Committed

wojnilowicz

Nov 18 2017, 4:48 PM

Differential Revision

D8878: Refactor widgets

Parents

R261:107ca045f3f5: Fix crash after editing investment transaction

Branches

Unknown

Tags

Unknown

wojnilowicz committed R261:802c8f4b98b0: Refactor widgets (authored by wojnilowicz).Nov 18 2017, 4:48 PM

Changes (283)
Show All Changes

Very Large Commit

This commit is very large. Load each file individually.

				Path	Packages
	M			kmymoney/converter/mymoneygncreader.cpp
	M			kmymoney/converter/mymoneystatementreader.cpp
	M			kmymoney/dialogs/CMakeLists.txt
	M			kmymoney/dialogs/investactivities.cpp
	M			kmymoney/dialogs/investactivities.h
	M			kmymoney/dialogs/investtransactioneditor.cpp
	M			kmymoney/dialogs/investtransactioneditor.h
	M			kmymoney/dialogs/kcategoryreassigndlg.cpp
	M			kmymoney/dialogs/kcurrencycalculator.cpp
	M			kmymoney/dialogs/kcurrencycalculator.ui
	M			kmymoney/dialogs/keditscheduledlg.cpp
	M			kmymoney/dialogs/keditscheduledlg.ui
	M			kmymoney/dialogs/kenterscheduledlg.cpp
	M			kmymoney/dialogs/kequitypriceupdatedlg.cpp
	M			kmymoney/dialogs/kequitypriceupdatedlg.ui
	M			kmymoney/dialogs/kfindtransactiondlg.ui
	M			kmymoney/dialogs/kfindtransactiondlg_p.h
	M			kmymoney/dialogs/kgeneratesqldlg.cpp
	M			kmymoney/dialogs/kmymoneysplittable.cpp
	M			kmymoney/dialogs/knewaccountdlg.cpp
	M			kmymoney/dialogs/knewaccountdlg.ui
	M			kmymoney/dialogs/knewbankdlg.cpp
	M			kmymoney/dialogs/knewequityentrydlg.cpp
	M			kmymoney/dialogs/knewequityentrydlg.ui
	M			kmymoney/dialogs/konlinetransferform.cpp
	M			kmymoney/dialogs/konlinetransferform.h
	M			kmymoney/dialogs/konlinetransferform.ui
	M			kmymoney/dialogs/kpayeereassigndlg.cpp
	M			kmymoney/dialogs/kpayeereassigndlg.ui
	M			kmymoney/dialogs/kselectdatabasedlg.cpp
	P			kmymoney/dialogs/kselectdatabasedlg.h Copied to kmymoney/widgets/kmymoneymvccombo_p.h
	M			kmymoney/dialogs/kselecttransactionsdlg.cpp
	M			kmymoney/dialogs/ksortoptiondlg.ui
	M			kmymoney/dialogs/ksplittransactiondlg.ui
	M			kmymoney/dialogs/ktagreassigndlg.cpp
	M			kmymoney/dialogs/ktagreassigndlg.ui
	M			kmymoney/dialogs/kupdatestockpricedlg.ui
	M			kmymoney/dialogs/settings/ksettingsgeneral.cpp
	M			kmymoney/dialogs/settings/ksettingsgeneral.ui
	M			kmymoney/dialogs/settings/ksettingsregister.ui
	M			kmymoney/dialogs/stdtransactioneditor.cpp
	M			kmymoney/dialogs/stdtransactioneditor.h
	M			kmymoney/dialogs/transactioneditor.cpp
	M			kmymoney/dialogs/transactioneditor.h
	M			kmymoney/dialogs/transactioneditor_p.h
	M			kmymoney/kmymoney.cpp
	M			kmymoney/kmymoney.h
	M			kmymoney/payeeidentifier/ibanandbic/widgets/bicvalidator.cpp
	M			kmymoney/payeeidentifier/ibanandbic/widgets/bicvalidator.h
	M			kmymoney/payeeidentifier/ibanandbic/widgets/ibanvalidator.cpp
	M			kmymoney/payeeidentifier/ibanandbic/widgets/ibanvalidator.h
	M			kmymoney/payeeidentifier/ibanandbic/widgets/kbicedit.cpp
	M			kmymoney/payeeidentifier/ibanandbic/widgets/kbicedit.h
	M			kmymoney/payeeidentifier/ibanandbic/widgets/kibanlineedit.cpp
	M			kmymoney/payeeidentifier/ibanandbic/widgets/kibanlineedit.h
	M			kmymoney/plugins/interfaces/kmmviewinterface.cpp
	M			kmymoney/plugins/kbanking/dialogs/kbpickstartdate.ui
	M			kmymoney/plugins/ofximport/dialogs/konlinebankingstatusdecl.ui
	M			kmymoney/plugins/onlinetasks/interfaces/ui/ionlinejobedit.h
	M			kmymoney/plugins/onlinetasks/sepa/ui/sepacredittransferedit.cpp
	M			kmymoney/plugins/onlinetasks/sepa/ui/sepacredittransferedit.h
	M			kmymoney/plugins/onlinetasks/sepa/ui/sepacredittransferedit.ui
	M			kmymoney/plugins/printcheck/CMakeLists.txt
	M			kmymoney/plugins/printcheck/printcheck.cpp
	M			kmymoney/plugins/printcheck/printcheck.h
	M			kmymoney/plugins/qif/export/kexportdlgdecl.ui
	M			kmymoney/views/kbudgetview.ui
	M			kmymoney/views/kgloballedgerview.cpp
	M			kmymoney/views/kgloballedgerview.h
	M			kmymoney/views/khomeview.cpp
	M			kmymoney/views/kmymoneyview.cpp
	M			kmymoney/views/kmymoneyview.h
	M			kmymoney/views/kpayeesview.cpp
	M			kmymoney/views/kscheduledview.cpp
	M			kmymoney/views/ktagsview.cpp
	M			kmymoney/views/ktagsview_p.h
	M			kmymoney/views/newspliteditor.cpp
	M			kmymoney/views/newtransactioneditor.cpp
	M			kmymoney/widgets/CMakeLists.txt
	M			kmymoney/widgets/amountedit.cpp
	M			kmymoney/widgets/amountedit.h
	A			kmymoney/widgets/creditdebithelper.cpp
	A			kmymoney/widgets/creditdebithelper.h
	M			kmymoney/widgets/daterangedlg.cpp
	M			kmymoney/widgets/daterangedlg.h
	V			kmymoney/widgets/{daterangedlg.ui ← daterangedlgdecl.ui}
	V			kmymoney/widgets/{daterangedlgdecl.ui → daterangedlg.ui}
	A			kmymoney/widgets/fancydategroupmarker.cpp
	P			kmymoney/widgets/fancydategroupmarker.h Copied from kmymoney/widgets/transactioneditorcontainer.cpp
	P			kmymoney/widgets/fancydategroupmarker_p.h Copied from kmymoney/widgets/transactioneditorcontainer.cpp
	A			kmymoney/widgets/fancydategroupmarkers.cpp
	A			kmymoney/widgets/fancydategroupmarkers.h
	M			kmymoney/widgets/fixedcolumntreeview.cpp
	M			kmymoney/widgets/fixedcolumntreeview.h
	A			kmymoney/widgets/groupmarker.cpp
	P			kmymoney/widgets/groupmarker.h Copied from kmymoney/widgets/transactioneditorcontainer.h
	A			kmymoney/widgets/groupmarker_p.h
	A			kmymoney/widgets/groupmarkers.cpp
	A			kmymoney/widgets/groupmarkers.h
	A			kmymoney/widgets/investtransaction.cpp
	A			kmymoney/widgets/investtransaction.h
	P			kmymoney/widgets/investtransaction_p.h Copied from kmymoney/widgets/scheduledtransaction.cpp
	A			kmymoney/widgets/itemptrvector.cpp
	P			kmymoney/widgets/itemptrvector.h Copied from kmymoney/widgets/transactioneditorcontainer.cpp
	M			kmymoney/widgets/kaccounttemplateselector.cpp
	M			kmymoney/widgets/kaccounttemplateselector.h
	V			kmymoney/widgets/{kaccounttemplateselector.ui ← kaccounttemplateselectordecl.ui}
	V			kmymoney/widgets/{kaccounttemplateselectordecl.ui → kaccounttemplateselector.ui}
	M			kmymoney/widgets/kbudgetvalues.cpp
	M			kmymoney/widgets/kbudgetvalues.h
	V			kmymoney/widgets/{kbudgetvalues.ui ← kbudgetvaluesdecl.ui}
	V			kmymoney/widgets/{kbudgetvaluesdecl.ui → kbudgetvalues.ui}
	M			kmymoney/widgets/kguiutils.cpp
	M			kmymoney/widgets/kguiutils.h
	M			kmymoney/widgets/kmymoneyaccountcombo.cpp
	M			kmymoney/widgets/kmymoneyaccountcombo.h
	M			kmymoney/widgets/kmymoneyaccountcompletion.cpp
	P			kmymoney/widgets/kmymoneyaccountcompletion.h Copied to kmymoney/widgets/kmymoneycompletion_p.h
	M			kmymoney/widgets/kmymoneyaccountselector.cpp
	M			kmymoney/widgets/kmymoneyaccountselector.h
	M			kmymoney/widgets/kmymoneyaccounttreeview.cpp
	M			kmymoney/widgets/kmymoneyaccounttreeview.h
	A			kmymoney/widgets/kmymoneyactivitycombo.cpp
	A			kmymoney/widgets/kmymoneyactivitycombo.h
	M			kmymoney/widgets/kmymoneybriefschedule.cpp
	M			kmymoney/widgets/kmymoneybriefschedule.h
	A			kmymoney/widgets/kmymoneybriefschedule.ui
	M			kmymoney/widgets/kmymoneycalculator.cpp
	M			kmymoney/widgets/kmymoneycalculator.h
	A			kmymoney/widgets/kmymoneycashflowcombo.cpp
	A			kmymoney/widgets/kmymoneycashflowcombo.h
	M			kmymoney/widgets/kmymoneycategory.cpp
	M			kmymoney/widgets/kmymoneycategory.h
	M			kmymoney/widgets/kmymoneycombo.cpp
	M			kmymoney/widgets/kmymoneycombo.h
	A			kmymoney/widgets/kmymoneycombo_p.h
	M			kmymoney/widgets/kmymoneycompletion.cpp
	M			kmymoney/widgets/kmymoneycompletion.h
	P			kmymoney/widgets/kmymoneycompletion_p.h Copied from kmymoney/widgets/kmymoneyaccountcompletion.h
	M			kmymoney/widgets/kmymoneycurrencyselector.cpp
	M			kmymoney/widgets/kmymoneycurrencyselector.h
	M			kmymoney/widgets/kmymoneydateedit.h
	M			kmymoney/widgets/kmymoneydateinput.cpp
	M			kmymoney/widgets/kmymoneydateinput.h
	M			kmymoney/widgets/kmymoneyedit.cpp
	M			kmymoney/widgets/kmymoneyedit.h
	A			kmymoney/widgets/kmymoneyfrequencycombo.cpp
	A			kmymoney/widgets/kmymoneyfrequencycombo.h
	A			kmymoney/widgets/kmymoneygeneralcombo.cpp
	A			kmymoney/widgets/kmymoneygeneralcombo.h
	M			kmymoney/widgets/kmymoneylineedit.cpp
	M			kmymoney/widgets/kmymoneylineedit.h
	M			kmymoney/widgets/kmymoneymvccombo.cpp
	M			kmymoney/widgets/kmymoneymvccombo.h
	P			kmymoney/widgets/kmymoneymvccombo_p.h Copied from kmymoney/dialogs/kselectdatabasedlg.h
	P			kmymoney/widgets/kmymoneyoccurrencecombo.cpp Copied from kmymoney/widgets/kpricetreeitem.h
	P			kmymoney/widgets/kmymoneyoccurrencecombo.h Copied from kmymoney/widgets/kmymoneywizard_p.h
	A			kmymoney/widgets/kmymoneyoccurrenceperiodcombo.cpp
	P			kmymoney/widgets/kmymoneyoccurrenceperiodcombo.h Copied from kmymoney/widgets/kmymoneywizard_p.h
	A			kmymoney/widgets/kmymoneypayeecombo.cpp
	A			kmymoney/widgets/kmymoneypayeecombo.h
	A			kmymoney/widgets/kmymoneyperiodcombo.cpp
	A			kmymoney/widgets/kmymoneyperiodcombo.h
	A			kmymoney/widgets/kmymoneyreconcilecombo.cpp
	P			kmymoney/widgets/kmymoneyreconcilecombo.h Copied from kmymoney/widgets/kmymoneywizard_p.h
	M			kmymoney/widgets/kmymoneyselector.cpp
	M			kmymoney/widgets/kmymoneyselector.h
	A			kmymoney/widgets/kmymoneyselector_p.h
	A			kmymoney/widgets/kmymoneytagcombo.cpp
	A			kmymoney/widgets/kmymoneytagcombo.h
	M			kmymoney/widgets/kmymoneytextedit.cpp
	M			kmymoney/widgets/kmymoneytextedit.h
	V			kmymoney/widgets/{kmymoneytextedit_p.h → kmymoneytextedithighlighter.h}
	A			kmymoney/widgets/kmymoneytextedithighlighter.cpp
	V			kmymoney/widgets/{kmymoneytextedithighlighter.h ← kmymoneytextedit_p.h}
	M			kmymoney/widgets/kmymoneytitlelabel.cpp
	M			kmymoney/widgets/kmymoneytitlelabel.h
	M			kmymoney/widgets/kmymoneyvalidationfeedback.cpp
	M			kmymoney/widgets/kmymoneyvalidationfeedback.h
	M			kmymoney/widgets/kmymoneywizard.cpp
	P			kmymoney/widgets/kmymoneywizard.h Copied to kmymoney/widgets/kmymoneywizardpage.h
	P			kmymoney/widgets/kmymoneywizard_p.h Copied to multiple locations: kmymoney/widgets/kmymoneyoccurrencecombo.h kmymoney/widgets/kmymoneyoccurrenceperiodcombo.h kmymoney/widgets/kmymoneyreconcilecombo.h kmymoney/widgets/ktaglabel.h
	A			kmymoney/widgets/kmymoneywizardpage.cpp
	P			kmymoney/widgets/kmymoneywizardpage.h Copied from kmymoney/widgets/kmymoneywizard.h
	P			kmymoney/widgets/kpricetreeitem.h Copied to kmymoney/widgets/kmymoneyoccurrencecombo.cpp
	D			kmymoney/widgets/kschedulebriefwidget.ui
	A			kmymoney/widgets/ktagcontainer.cpp
	A			kmymoney/widgets/ktagcontainer.h
	A			kmymoney/widgets/ktaglabel.cpp
	P			kmymoney/widgets/ktaglabel.h Copied from kmymoney/widgets/kmymoneywizard_p.h
	M			kmymoney/widgets/ktreewidgetfilterlinewidget.cpp
	M			kmymoney/widgets/ktreewidgetfilterlinewidget.h
	M			kmymoney/widgets/onlinejobmessagesview.cpp
	M			kmymoney/widgets/onlinejobmessagesview.h
	P			kmymoney/widgets/qwidgetcontainer.cpp Copied from kmymoney/widgets/transactioneditorcontainer.cpp
	P			kmymoney/widgets/qwidgetcontainer.h Copied from kmymoney/widgets/transactioneditorcontainer.cpp
	M			kmymoney/widgets/register.cpp
	M			kmymoney/widgets/register.h
	P			kmymoney/widgets/registerfilter.cpp Copied from kmymoney/widgets/transactioneditorcontainer.cpp
	P			kmymoney/widgets/registerfilter.h Copied from kmymoney/widgets/transactioneditorcontainer.cpp
	M			kmymoney/widgets/registeritem.cpp
	M			kmymoney/widgets/registeritem.h
	A			kmymoney/widgets/registeritem_p.h
	P			kmymoney/widgets/registeritemdelegate.cpp Copied from kmymoney/widgets/scheduledtransaction.cpp
	P			kmymoney/widgets/registeritemdelegate.h Copied from kmymoney/widgets/transactioneditorcontainer.cpp
	M			kmymoney/widgets/registersearchline.cpp
	M			kmymoney/widgets/registersearchline.h
	M			kmymoney/widgets/reportcontrolimpl.cpp
	M			kmymoney/widgets/reportcontrolimpl.h
	M			kmymoney/widgets/reporttabcapitalgain.ui
	M			kmymoney/widgets/reporttabchart.ui
	M			kmymoney/widgets/reporttabimpl.cpp
	M			kmymoney/widgets/reporttabimpl.h
	M			kmymoney/widgets/reporttabrowcolpivot.ui
	P			kmymoney/widgets/scheduledtransaction.cpp Copied to multiple locations: kmymoney/widgets/investtransaction_p.h kmymoney/widgets/registeritemdelegate.cpp kmymoney/widgets/selectedtransactions.h
	M			kmymoney/widgets/scheduledtransaction.h
	P			kmymoney/widgets/selectedtransaction.cpp Copied to kmymoney/widgets/selectedtransactions.cpp
	M			kmymoney/widgets/selectedtransaction.h
	P			kmymoney/widgets/selectedtransactions.cpp Copied from kmymoney/widgets/selectedtransaction.cpp
	P			kmymoney/widgets/selectedtransactions.h Copied from kmymoney/widgets/scheduledtransaction.cpp
	A			kmymoney/widgets/stdtransaction.cpp
	A			kmymoney/widgets/stdtransaction.h
	P			kmymoney/widgets/stdtransaction_p.h Copied from kmymoney/widgets/transactioneditorcontainer.cpp
	M			kmymoney/widgets/stdtransactiondownloaded.cpp
	M			kmymoney/widgets/stdtransactiondownloaded.h
	M			kmymoney/widgets/stdtransactionmatched.cpp
	M			kmymoney/widgets/stdtransactionmatched.h
	M			kmymoney/widgets/styleditemdelegateforwarder.cpp
	A			kmymoney/widgets/tabbar.cpp
	A			kmymoney/widgets/tabbar.h
	M			kmymoney/widgets/transaction.cpp
	M			kmymoney/widgets/transaction.h
	A			kmymoney/widgets/transaction_p.h
	P			kmymoney/widgets/transactioneditorcontainer.cpp Copied to multiple locations: kmymoney/widgets/fancydategroupmarker.h kmymoney/widgets/fancydategroupmarker_p.h kmymoney/widgets/itemptrvector.h kmymoney/widgets/qwidgetcontainer.cpp kmymoney/widgets/qwidgetcontainer.h kmymoney/widgets/registerfilter.cpp kmymoney/widgets/registerfilter.h kmymoney/widgets/registeritemdelegate.h kmymoney/widgets/stdtransaction_p.h kmymoney/widgets/transactionformitemdelegate.cpp kmymoney/widgets/transactionformitemdelegate.h
	P			kmymoney/widgets/transactioneditorcontainer.h Copied to kmymoney/widgets/groupmarker.h
	M			kmymoney/widgets/transactionform.cpp
	M			kmymoney/widgets/transactionform.h
	P			kmymoney/widgets/transactionformitemdelegate.cpp Copied from kmymoney/widgets/transactioneditorcontainer.cpp
	P			kmymoney/widgets/transactionformitemdelegate.h Copied from kmymoney/widgets/transactioneditorcontainer.cpp
	V			kmymoney/widgets/{transactionsortoption.cpp ← transactionsortoptionimpl.cpp}
	V			kmymoney/widgets/{transactionsortoption.h ← transactionsortoptionimpl.h}
	V			kmymoney/widgets/{transactionsortoption.ui ← transactionsortoptiondecl.ui}
	V			kmymoney/widgets/{transactionsortoptiondecl.ui → transactionsortoption.ui}
	V			kmymoney/widgets/{transactionsortoptionimpl.cpp → transactionsortoption.cpp}
	V			kmymoney/widgets/{transactionsortoptionimpl.h → transactionsortoption.h}
	A			kmymoney/widgets/widgetenums.h
	M			kmymoney/wizards/endingbalancedlg/checkingstatementinfowizardpagedecl.ui
	M			kmymoney/wizards/endingbalancedlg/interestchargecheckingswizardpagedecl.ui
	M			kmymoney/wizards/endingbalancedlg/kendingbalancedlg.cpp
	M			kmymoney/wizards/endingbalancedlg/kendingbalancedlg.h
	M			kmymoney/wizards/endingbalancedlg/kendingbalancedlgdecl.ui
	M			kmymoney/wizards/newaccountwizard/kaccounttypepagedecl.ui
	M			kmymoney/wizards/newaccountwizard/kgeneralloaninfopagedecl.ui
	M			kmymoney/wizards/newaccountwizard/kloandetailspagedecl.ui
	M			kmymoney/wizards/newaccountwizard/kloanpayoutpagedecl.ui
	M			kmymoney/wizards/newaccountwizard/kloanschedulepagedecl.ui
	M			kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp
	M			kmymoney/wizards/newaccountwizard/knewaccountwizard_p.h
	M			kmymoney/wizards/newaccountwizard/kschedulepagedecl.ui
	M			kmymoney/wizards/newinvestmentwizard/kinvestmentdetailswizardpage.cpp
	M			kmymoney/wizards/newinvestmentwizard/kinvestmentdetailswizardpage.h
	M			kmymoney/wizards/newinvestmentwizard/kinvestmentdetailswizardpage.ui
	M			kmymoney/wizards/newinvestmentwizard/konlineupdatewizardpage.cpp
	M			kmymoney/wizards/newinvestmentwizard/konlineupdatewizardpage.ui
	M			kmymoney/wizards/newloanwizard/assetaccountwizardpage.ui
	M			kmymoney/wizards/newloanwizard/durationwizardpage.ui
	M			kmymoney/wizards/newloanwizard/effectivedatewizardpage.ui
	M			kmymoney/wizards/newloanwizard/finalpaymentwizardpage.ui
	M			kmymoney/wizards/newloanwizard/firstpaymentwizardpage.ui
	M			kmymoney/wizards/newloanwizard/interestcategorywizardpage.ui
	M			kmymoney/wizards/newloanwizard/interesteditwizardpage.ui
	M			kmymoney/wizards/newloanwizard/interestwizardpage.ui
	M			kmymoney/wizards/newloanwizard/keditloanwizard.cpp
	M			kmymoney/wizards/newloanwizard/knewloanwizard.ui
	M			kmymoney/wizards/newloanwizard/loanamountwizardpage.ui
	M			kmymoney/wizards/newloanwizard/namewizardpage.ui
	M			kmymoney/wizards/newloanwizard/paymenteditwizardpage.ui
	M			kmymoney/wizards/newloanwizard/paymentfrequencywizardpage.ui
	M			kmymoney/wizards/newloanwizard/paymentwizardpage.ui
	M			kmymoney/wizards/newloanwizard/schedulewizardpage.ui
	M			kmymoney/wizards/newloanwizard/variableinterestdatewizardpage.ui
	M			kmymoney/wizards/newuserwizard/kaccountpagedecl.ui
	M			kmymoney/wizards/newuserwizard/knewuserwizard_p.h