Differential D8878

Refactor widgets
AbandonedPublic
Actions

Authored by wojnilowicz on Nov 18 2017, 10:26 AM.

Details

Reviewers

tbaumgart

Group Reviewers

KMyMoney

Commits

R261:802c8f4b98b0: Refactor widgets

Summary

Patch aims mainly to speed up recompilation time through code refactoring. Refactoring in this case means:

new syntax for signal-slot connections,
enums in separate header file,
single class in single header,
d-pointers,
single inheritance for widget classes,
explicit constructors,
less interdependency in header files,
override keyword for virtual functions,
disabling copy constructors,
rename kMyMoney* to KMymoney* to be consistent.

Test Plan

Tested some dialogs and wizards.

Diff Detail

Repository

R261 KMyMoney

Lint

Lint Skipped

Unit

Unit Tests Skipped

wojnilowicz created this revision.Nov 18 2017, 10:26 AM

I found two more spots that need to be changed as well before the compiler is happy:

thb@thb-nb:~/devel/kmymoney/kmymoney/plugins/kbanking (master *)$ git grep kMyMoneyDateInput
dialogs/kbpickstartdate.ui:       <widget class="kMyMoneyDateInput" name="pickDa
dialogs/kbpickstartdate.ui:   <class>kMyMoneyDateInput</class>

Other than that, the patch seems fine to me.

This revision now requires changes to proceed.Nov 18 2017, 12:05 PM

wojnilowicz abandoned this revision.Nov 18 2017, 5:04 PM

Large Diff

This large diff affects 282 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

		Path
M		kmymoney/converter/mymoneygncreader.cpp (3 lines)
M		kmymoney/converter/mymoneystatementreader.cpp (2 lines)
M		kmymoney/dialogs/CMakeLists.txt (2 lines)
M		kmymoney/dialogs/investactivities.h (4 lines)
M		kmymoney/dialogs/investactivities.cpp (54 lines)
M		kmymoney/dialogs/investtransactioneditor.h (2 lines)
M		kmymoney/dialogs/investtransactioneditor.cpp (90 lines)
M		kmymoney/dialogs/kcategoryreassigndlg.cpp (2 lines)
M		kmymoney/dialogs/kcurrencycalculator.cpp (5 lines)
M		kmymoney/dialogs/kcurrencycalculator.ui (10 lines)
M		kmymoney/dialogs/keditscheduledlg.cpp (57 lines)
M		kmymoney/dialogs/keditscheduledlg.ui (8 lines)
M		kmymoney/dialogs/kenterscheduledlg.cpp (25 lines)
M		kmymoney/dialogs/kequitypriceupdatedlg.cpp (4 lines)
M		kmymoney/dialogs/kequitypriceupdatedlg.ui (6 lines)
M		kmymoney/dialogs/kfindtransactiondlg.ui (22 lines)
M		kmymoney/dialogs/kfindtransactiondlg_p.h (34 lines)
M		kmymoney/dialogs/kgeneratesqldlg.cpp (4 lines)
M		kmymoney/dialogs/kmymoneysplittable.cpp (12 lines)
M		kmymoney/dialogs/knewaccountdlg.cpp (18 lines)
M		kmymoney/dialogs/knewaccountdlg.ui (24 lines)
M		kmymoney/dialogs/knewbankdlg.cpp (2 lines)
M		kmymoney/dialogs/knewequityentrydlg.cpp (2 lines)
M		kmymoney/dialogs/knewequityentrydlg.ui (4 lines)
M		kmymoney/dialogs/konlinetransferform.h (4 lines)
M		kmymoney/dialogs/konlinetransferform.cpp (4 lines)
M		kmymoney/dialogs/konlinetransferform.ui (4 lines)
M		kmymoney/dialogs/kpayeereassigndlg.cpp (2 lines)
M		kmymoney/dialogs/kpayeereassigndlg.ui (2 lines)
M		kmymoney/dialogs/kselectdatabasedlg.h (4 lines)
M		kmymoney/dialogs/kselectdatabasedlg.cpp (2 lines)
M		kmymoney/dialogs/kselecttransactionsdlg.cpp (9 lines)
M		kmymoney/dialogs/ksortoptiondlg.ui (2 lines)
M		kmymoney/dialogs/ksplittransactiondlg.ui (2 lines)
M		kmymoney/dialogs/ktagreassigndlg.cpp (2 lines)
M		kmymoney/dialogs/ktagreassigndlg.ui (2 lines)
M		kmymoney/dialogs/kupdatestockpricedlg.ui (4 lines)
M		kmymoney/dialogs/settings/ksettingsgeneral.cpp (2 lines)
M		kmymoney/dialogs/settings/ksettingsgeneral.ui (4 lines)
M		kmymoney/dialogs/settings/ksettingsregister.ui (2 lines)
M		kmymoney/dialogs/stdtransactioneditor.h (6 lines)
M		kmymoney/dialogs/stdtransactioneditor.cpp (260 lines)
M		kmymoney/dialogs/transactioneditor.h (7 lines)
M		kmymoney/dialogs/transactioneditor.cpp (37 lines)
M		kmymoney/dialogs/transactioneditor_p.h (10 lines)
M		kmymoney/kmymoney.h (4 lines)
M		kmymoney/kmymoney.cpp (6 lines)
M		kmymoney/payeeidentifier/ibanandbic/widgets/bicvalidator.h (4 lines)
M		kmymoney/payeeidentifier/ibanandbic/widgets/bicvalidator.cpp (9 lines)
M		kmymoney/payeeidentifier/ibanandbic/widgets/ibanvalidator.h (4 lines)
M		kmymoney/payeeidentifier/ibanandbic/widgets/ibanvalidator.cpp (10 lines)
M		kmymoney/payeeidentifier/ibanandbic/widgets/kbicedit.h (3 lines)
M		kmymoney/payeeidentifier/ibanandbic/widgets/kbicedit.cpp (1 line)
M		kmymoney/payeeidentifier/ibanandbic/widgets/kibanlineedit.h (4 lines)
M		kmymoney/payeeidentifier/ibanandbic/widgets/kibanlineedit.cpp (2 lines)
M		kmymoney/plugins/interfaces/kmmviewinterface.cpp (2 lines)
M		kmymoney/plugins/ofximport/dialogs/konlinebankingstatusdecl.ui (4 lines)
M		kmymoney/plugins/onlinetasks/interfaces/ui/ionlinejobedit.h (2 lines)
M		kmymoney/plugins/onlinetasks/sepa/ui/sepacredittransferedit.h (4 lines)
M		kmymoney/plugins/onlinetasks/sepa/ui/sepacredittransferedit.cpp (21 lines)
M		kmymoney/plugins/onlinetasks/sepa/ui/sepacredittransferedit.ui (4 lines)
M		kmymoney/plugins/printcheck/CMakeLists.txt (1 line)
M		kmymoney/plugins/printcheck/printcheck.h (2 lines)
M		kmymoney/plugins/printcheck/printcheck.cpp (1 line)
M		kmymoney/plugins/qif/export/kexportdlgdecl.ui (6 lines)
M		kmymoney/views/kbudgetview.ui (4 lines)
M		kmymoney/views/kgloballedgerview.h (12 lines)
M		kmymoney/views/kgloballedgerview.cpp (58 lines)
M		kmymoney/views/khomeview.cpp (2 lines)
M		kmymoney/views/kmymoneyview.h (3 lines)
M		kmymoney/views/kmymoneyview.cpp (4 lines)
M		kmymoney/views/kpayeesview.cpp (20 lines)
M		kmymoney/views/kscheduledview.cpp (2 lines)
M		kmymoney/views/ktagsview.cpp (3 lines)
M		kmymoney/views/ktagsview_p.h (16 lines)
M		kmymoney/views/newspliteditor.cpp (1 line)
M		kmymoney/views/newtransactioneditor.cpp (1 line)
M		kmymoney/widgets/CMakeLists.txt (46 lines)
M		kmymoney/widgets/amountedit.h (116 lines)
M		kmymoney/widgets/amountedit.cpp (336 lines)
A	M	kmymoney/widgets/creditdebithelper.h (81 lines)
A	M	kmymoney/widgets/creditdebithelper.cpp (137 lines)
M		kmymoney/widgets/daterangedlg.h (24 lines)
M		kmymoney/widgets/daterangedlg.cpp (120 lines)
V		kmymoney/widgets/{daterangedlg.ui ← daterangedlgdecl.ui} (12 lines)
V		kmymoney/widgets/{daterangedlgdecl.ui → daterangedlg.ui}
A	M	kmymoney/widgets/fancydategroupmarker.h (54 lines)
A	M	kmymoney/widgets/fancydategroupmarker.cpp (71 lines)
A	M	kmymoney/widgets/fancydategroupmarker_p.h (44 lines)
A	M	kmymoney/widgets/fancydategroupmarkers.h (86 lines)
A	M	kmymoney/widgets/fancydategroupmarkers.cpp (134 lines)
M		kmymoney/widgets/fixedcolumntreeview.h (6 lines)
M		kmymoney/widgets/fixedcolumntreeview.cpp (34 lines)
A	M	kmymoney/widgets/groupmarker.h (69 lines)
A	M	kmymoney/widgets/groupmarker.cpp (187 lines)
A	M	kmymoney/widgets/groupmarker_p.h (114 lines)
A	M	kmymoney/widgets/groupmarkers.h (98 lines)
A	M	kmymoney/widgets/groupmarkers.cpp (237 lines)
A	M	kmymoney/widgets/investtransaction.h (103 lines)
A	M	kmymoney/widgets/investtransaction.cpp (934 lines)
A	M	kmymoney/widgets/investtransaction_p.h (60 lines)
A	M	kmymoney/widgets/itemptrvector.h (49 lines)
A	M	kmymoney/widgets/itemptrvector.cpp (158 lines)
M		kmymoney/widgets/kaccounttemplateselector.h (28 lines)
M		kmymoney/widgets/kaccounttemplateselector.cpp (109 lines)
V		kmymoney/widgets/{kaccounttemplateselector.ui ← kaccounttemplateselectordecl.ui} (4 lines)
V		kmymoney/widgets/{kaccounttemplateselectordecl.ui → kaccounttemplateselector.ui}
M		kmymoney/widgets/kbudgetvalues.h (39 lines)
M		kmymoney/widgets/kbudgetvalues.cpp (351 lines)
V		kmymoney/widgets/{kbudgetvalues.ui ← kbudgetvaluesdecl.ui} (34 lines)
V		kmymoney/widgets/{kbudgetvaluesdecl.ui → kbudgetvalues.ui}
M		kmymoney/widgets/kguiutils.h (24 lines)
M		kmymoney/widgets/kguiutils.cpp (133 lines)
M		kmymoney/widgets/kmymoneyaccountcombo.h (17 lines)
M		kmymoney/widgets/kmymoneyaccountcombo.cpp (13 lines)
M		kmymoney/widgets/kmymoneyaccountcompletion.h (26 lines)
M		kmymoney/widgets/kmymoneyaccountcompletion.cpp (56 lines)
M		kmymoney/widgets/kmymoneyaccountselector.h (83 lines)
M		kmymoney/widgets/kmymoneyaccountselector.cpp (348 lines)
M		kmymoney/widgets/kmymoneyaccounttreeview.h (31 lines)
M		kmymoney/widgets/kmymoneyaccounttreeview.cpp (188 lines)
A	M	kmymoney/widgets/kmymoneyactivitycombo.h (68 lines)
A	M	kmymoney/widgets/kmymoneyactivitycombo.cpp (98 lines)
M		kmymoney/widgets/kmymoneybriefschedule.h (30 lines)
M		kmymoney/widgets/kmymoneybriefschedule.cpp (220 lines)
A	M	kmymoney/widgets/kmymoneybriefschedule.ui (376 lines)
M		kmymoney/widgets/kmymoneycalculator.h (105 lines)
M		kmymoney/widgets/kmymoneycalculator.cpp (521 lines)
A	M	kmymoney/widgets/kmymoneycashflowcombo.h (72 lines)
A	M	kmymoney/widgets/kmymoneycashflowcombo.cpp (105 lines)
M		kmymoney/widgets/kmymoneycategory.h (51 lines)
M		kmymoney/widgets/kmymoneycategory.cpp (68 lines)
M		kmymoney/widgets/kmymoneycombo.h (79 lines)
M		kmymoney/widgets/kmymoneycombo.cpp (152 lines)
A	M	kmymoney/widgets/kmymoneycombo_p.h (81 lines)
M		kmymoney/widgets/kmymoneycompletion.h (39 lines)
M		kmymoney/widgets/kmymoneycompletion.cpp (180 lines)
A	M	kmymoney/widgets/kmymoneycompletion_p.h (60 lines)
M		kmymoney/widgets/kmymoneycurrencyselector.h (41 lines)
M		kmymoney/widgets/kmymoneycurrencyselector.cpp (108 lines)
M		kmymoney/widgets/kmymoneydateedit.h (2 lines)
M		kmymoney/widgets/kmymoneydateinput.h (14 lines)
M		kmymoney/widgets/kmymoneydateinput.cpp (51 lines)
M		kmymoney/widgets/kmymoneyedit.h (112 lines)
M		kmymoney/widgets/kmymoneyedit.cpp (574 lines)
A	M	kmymoney/widgets/kmymoneyfrequencycombo.h (78 lines)
A	M	kmymoney/widgets/kmymoneyfrequencycombo.cpp (90 lines)
A	M	kmymoney/widgets/kmymoneygeneralcombo.h (69 lines)
A	M	kmymoney/widgets/kmymoneygeneralcombo.cpp (69 lines)
M		kmymoney/widgets/kmymoneylineedit.h (14 lines)
M		kmymoney/widgets/kmymoneylineedit.cpp (20 lines)
M		kmymoney/widgets/kmymoneymvccombo.h (366 lines)
M		kmymoney/widgets/kmymoneymvccombo.cpp (646 lines)
A	M	kmymoney/widgets/kmymoneymvccombo_p.h (66 lines)
A	M	kmymoney/widgets/kmymoneyoccurrencecombo.h (55 lines)
A	M	kmymoney/widgets/kmymoneyoccurrencecombo.cpp (48 lines)
A	M	kmymoney/widgets/kmymoneyoccurrenceperiodcombo.h (51 lines)
A	M	kmymoney/widgets/kmymoneyoccurrenceperiodcombo.cpp (51 lines)
A	M	kmymoney/widgets/kmymoneypayeecombo.h (66 lines)
A	M	kmymoney/widgets/kmymoneypayeecombo.cpp (61 lines)
A	M	kmymoney/widgets/kmymoneyperiodcombo.h (70 lines)
A	M	kmymoney/widgets/kmymoneyperiodcombo.cpp (108 lines)
A	M	kmymoney/widgets/kmymoneyreconcilecombo.h (60 lines)
A	M	kmymoney/widgets/kmymoneyreconcilecombo.cpp (115 lines)
M		kmymoney/widgets/kmymoneyselector.h (47 lines)
M		kmymoney/widgets/kmymoneyselector.cpp (241 lines)
A	M	kmymoney/widgets/kmymoneyselector_p.h (93 lines)
A	M	kmymoney/widgets/kmymoneytagcombo.h (71 lines)
A	M	kmymoney/widgets/kmymoneytagcombo.cpp (131 lines)
M		kmymoney/widgets/kmymoneytextedit.h (32 lines)
M		kmymoney/widgets/kmymoneytextedit.cpp (210 lines)
V		kmymoney/widgets/{kmymoneytextedit_p.h → kmymoneytextedithighlighter.h}
V		kmymoney/widgets/{kmymoneytextedithighlighter.h ← kmymoneytextedit_p.h} (15 lines)
A	M	kmymoney/widgets/kmymoneytextedithighlighter.cpp (123 lines)
M		kmymoney/widgets/kmymoneytitlelabel.h (37 lines)
M		kmymoney/widgets/kmymoneytitlelabel.cpp (94 lines)
M		kmymoney/widgets/kmymoneyvalidationfeedback.h (29 lines)
M		kmymoney/widgets/kmymoneyvalidationfeedback.cpp (58 lines)
M		kmymoney/widgets/kmymoneywizard.h (271 lines)
M		kmymoney/widgets/kmymoneywizard.cpp (100 lines)
M		kmymoney/widgets/kmymoneywizard_p.h (1 line)
A	M	kmymoney/widgets/kmymoneywizardpage.h (289 lines)
A	M	kmymoney/widgets/kmymoneywizardpage.cpp (121 lines)
M		kmymoney/widgets/kpricetreeitem.h (3 lines)
D	M	kmymoney/widgets/kschedulebriefwidget.ui (322 lines)
A	M	kmymoney/widgets/ktagcontainer.h (72 lines)
A	M	kmymoney/widgets/ktagcontainer.cpp (144 lines)
A	M	kmymoney/widgets/ktaglabel.h (56 lines)
A	M	kmymoney/widgets/ktaglabel.cpp (55 lines)
M		kmymoney/widgets/ktreewidgetfilterlinewidget.h (3 lines)
M		kmymoney/widgets/ktreewidgetfilterlinewidget.cpp (1 line)
M		kmymoney/widgets/onlinejobmessagesview.h (8 lines)
M		kmymoney/widgets/onlinejobmessagesview.cpp (2 lines)
A	M	kmymoney/widgets/qwidgetcontainer.h (47 lines)
A	M	kmymoney/widgets/qwidgetcontainer.cpp (59 lines)
M		kmymoney/widgets/register.h (591 lines)
M		kmymoney/widgets/register.cpp (3397 lines)
A	M	kmymoney/widgets/registerfilter.h (49 lines)
A	M	kmymoney/widgets/registerfilter.cpp (38 lines)
M		kmymoney/widgets/registeritem.h (294 lines)
M		kmymoney/widgets/registeritem.cpp (256 lines)
A	M	kmymoney/widgets/registeritem_p.h (79 lines)
A	M	kmymoney/widgets/registeritemdelegate.h (57 lines)
A	M	kmymoney/widgets/registeritemdelegate.cpp (53 lines)
M		kmymoney/widgets/registersearchline.h (5 lines)
M		kmymoney/widgets/registersearchline.cpp (47 lines)
M		kmymoney/widgets/reportcontrolimpl.h (7 lines)
M		kmymoney/widgets/reportcontrolimpl.cpp (12 lines)
M		kmymoney/widgets/reporttabcapitalgain.ui (4 lines)
M		kmymoney/widgets/reporttabchart.ui (2 lines)
M		kmymoney/widgets/reporttabimpl.h (84 lines)
M		kmymoney/widgets/reporttabimpl.cpp (51 lines)
M		kmymoney/widgets/reporttabrowcolpivot.ui (2 lines)
M		kmymoney/widgets/scheduledtransaction.h (47 lines)
M		kmymoney/widgets/scheduledtransaction.cpp (37 lines)
M		kmymoney/widgets/selectedtransaction.h (99 lines)
M		kmymoney/widgets/selectedtransaction.cpp (108 lines)
A	M	kmymoney/widgets/selectedtransactions.h (57 lines)
A	M	kmymoney/widgets/selectedtransactions.cpp (59 lines)
A	M	kmymoney/widgets/stdtransaction.h (88 lines)
A	M	kmymoney/widgets/stdtransaction.cpp (699 lines)
A	M	kmymoney/widgets/stdtransaction_p.h (41 lines)
M		kmymoney/widgets/stdtransactiondownloaded.h (45 lines)
M		kmymoney/widgets/stdtransactiondownloaded.cpp (30 lines)
M		kmymoney/widgets/stdtransactionmatched.h (39 lines)
M		kmymoney/widgets/stdtransactionmatched.cpp (77 lines)
M		kmymoney/widgets/styleditemdelegateforwarder.cpp (6 lines)
A	M	kmymoney/widgets/tabbar.h (98 lines)
A	M	kmymoney/widgets/tabbar.cpp (200 lines)
M		kmymoney/widgets/transaction.h (454 lines)
M		kmymoney/widgets/transaction.cpp (1874 lines)
A	M	kmymoney/widgets/transaction_p.h (134 lines)
M		kmymoney/widgets/transactioneditorcontainer.h (24 lines)
M		kmymoney/widgets/transactioneditorcontainer.cpp (14 lines)
M		kmymoney/widgets/transactionform.h (210 lines)
M		kmymoney/widgets/transactionform.cpp (320 lines)
A	M	kmymoney/widgets/transactionformitemdelegate.h (51 lines)
A	M	kmymoney/widgets/transactionformitemdelegate.cpp (41 lines)
V		kmymoney/widgets/{transactionsortoption.h ← transactionsortoptionimpl.h} (21 lines)
V		kmymoney/widgets/{transactionsortoption.cpp ← transactionsortoptionimpl.cpp} (112 lines)
V		kmymoney/widgets/{transactionsortoption.ui ← transactionsortoptiondecl.ui} (4 lines)
V		kmymoney/widgets/{transactionsortoptiondecl.ui → transactionsortoption.ui}
V		kmymoney/widgets/{transactionsortoptionimpl.h → transactionsortoption.h}
V		kmymoney/widgets/{transactionsortoptionimpl.cpp → transactionsortoption.cpp}
A	M	kmymoney/widgets/widgetenums.h (134 lines)
M		kmymoney/wizards/endingbalancedlg/checkingstatementinfowizardpagedecl.ui (6 lines)
M		kmymoney/wizards/endingbalancedlg/interestchargecheckingswizardpagedecl.ui (10 lines)
M		kmymoney/wizards/endingbalancedlg/kendingbalancedlg.h (2 lines)
M		kmymoney/wizards/endingbalancedlg/kendingbalancedlg.cpp (2 lines)
M		kmymoney/wizards/endingbalancedlg/kendingbalancedlgdecl.ui (8 lines)
M		kmymoney/wizards/newaccountwizard/kaccounttypepagedecl.ui (12 lines)
M		kmymoney/wizards/newaccountwizard/kgeneralloaninfopagedecl.ui (10 lines)
M		kmymoney/wizards/newaccountwizard/kloandetailspagedecl.ui (10 lines)
M		kmymoney/wizards/newaccountwizard/kloanpayoutpagedecl.ui (2 lines)
M		kmymoney/wizards/newaccountwizard/kloanschedulepagedecl.ui (2 lines)
M		kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp (4 lines)
M		kmymoney/wizards/newaccountwizard/knewaccountwizard_p.h (3 lines)
M		kmymoney/wizards/newaccountwizard/kschedulepagedecl.ui (8 lines)
M		kmymoney/wizards/newinvestmentwizard/kinvestmentdetailswizardpage.h (2 lines)
M		kmymoney/wizards/newinvestmentwizard/kinvestmentdetailswizardpage.cpp (4 lines)
M		kmymoney/wizards/newinvestmentwizard/kinvestmentdetailswizardpage.ui (14 lines)
M		kmymoney/wizards/newinvestmentwizard/konlineupdatewizardpage.cpp (2 lines)
M		kmymoney/wizards/newinvestmentwizard/konlineupdatewizardpage.ui (2 lines)
M		kmymoney/wizards/newloanwizard/assetaccountwizardpage.ui (4 lines)
M		kmymoney/wizards/newloanwizard/durationwizardpage.ui (2 lines)
M		kmymoney/wizards/newloanwizard/effectivedatewizardpage.ui (2 lines)
M		kmymoney/wizards/newloanwizard/finalpaymentwizardpage.ui (2 lines)
M		kmymoney/wizards/newloanwizard/firstpaymentwizardpage.ui (2 lines)
M		kmymoney/wizards/newloanwizard/interestcategorywizardpage.ui (2 lines)
M		kmymoney/wizards/newloanwizard/interesteditwizardpage.ui (2 lines)
M		kmymoney/wizards/newloanwizard/interestwizardpage.ui (2 lines)
M		kmymoney/wizards/newloanwizard/keditloanwizard.cpp (1 line)
M		kmymoney/wizards/newloanwizard/knewloanwizard.ui (6 lines)
M		kmymoney/wizards/newloanwizard/loanamountwizardpage.ui (2 lines)
M		kmymoney/wizards/newloanwizard/namewizardpage.ui (4 lines)
M		kmymoney/wizards/newloanwizard/paymenteditwizardpage.ui (2 lines)
M		kmymoney/wizards/newloanwizard/paymentfrequencywizardpage.ui (2 lines)
M		kmymoney/wizards/newloanwizard/paymentwizardpage.ui (2 lines)
M		kmymoney/wizards/newloanwizard/schedulewizardpage.ui (4 lines)
M		kmymoney/wizards/newloanwizard/variableinterestdatewizardpage.ui (4 lines)
M		kmymoney/wizards/newuserwizard/kaccountpagedecl.ui (4 lines)
M		kmymoney/wizards/newuserwizard/knewuserwizard_p.h (1 line)