Don't put HeaderBar in a parent Item
ClosedPublic
Actions

Authored by ngraham on Jun 20 2019, 4:34 PM.

Details

Reviewers

mgallien

Group Reviewers

Elisa

Commits

R255:ba4352456015: Don't put HeaderBar in a parent Item

Summary

It seems unnecessary to have this kind of indirection, and now the code is simplified.

Test Plan

No visual changes in any case

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ngraham requested review of this revision.Jun 20 2019, 4:34 PM

ngraham created this revision.

Thanks

This revision is now accepted and ready to land.Jun 20 2019, 4:38 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/qml/ElisaMainWindow.qml (148 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	60151	74feb22		Jun 20 2019, 4:34 PM	★	★
Diff 2	60174	93bcbd0	R255:ba4352456015cf002ef4b97e1927adda8bb91cb5	Jun 20 2019, 10:35 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
18c063c802d9	e48c4a7b60fd	74feb222a6ce	Nate Graham	Don't put HeaderBar in a parent Item (Show More…)	Jun 20 2019, 4:33 PM