Diffusion KIO 591cc2a16e3e

Treat "application/x-ms-dos-executable" as executable on all platforms

Authored by Guo Yunhe <i@guoyunhe.me> on Oct 7 2019, 11:11 AM.

Description

Treat "application/x-ms-dos-executable" as executable on all platforms

Summary:
Because of Wine, *.exe can be executed in almost all desktop platforms.

The dialog will open when a script/exe/binary is clicked.

For scripts, it shows "Open" and "Execute" button. Same as before.

For *.exe on Linux/BSD, it shows only "Execute" button, but it actually does "Open with Wine".

For native binary, it shows only "Execute" button. This is a new difference. I think users should never click and run a binary without warning. Here is already a showUntrustedProgramWarning pop up function. But it only popup for binary without execute bit. If you get a binary from *.tar.gz or *.7z, it may already have a execute bit and no popup will be appear.

BUG: 412694

Reviewers: Frameworks, ngraham, dfaure

Reviewed By: ngraham, dfaure

Subscribers: GB_2, ppeter, dfaure, ngraham, broulik, kde-frameworks-devel

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D24463

Details

Committed
Guo Yunhe <i@guoyunhe.me>Oct 16 2019, 8:39 AM
Reviewer
ngraham
Differential Revision
D24463: Treat "application/x-ms-dos-executable" as executable on all platforms
Parents
R241:0911763b8f19: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()
Branches
Unknown
Tags
Unknown
Guo Yunhe <i@guoyunhe.me> committed R241:591cc2a16e3e: Treat "application/x-ms-dos-executable" as executable on all platforms (authored by Guo Yunhe <i@guoyunhe.me>).Oct 16 2019, 8:39 AM