KDateComboBox: fix dateChanged() not emitted after typing a date

Authored by dfaure on Mar 16 2018, 8:56 AM.

Description

KDateComboBox: fix dateChanged() not emitted after typing a date

Summary:
When editing an event in korganizer, if I was typing digits
to edit a date, rather than using another method (date popup; key_up;
etc.), then the change wouldn't be saved.

I would say that on focus-out or Key_Enter, we want to "commit"
the edited date into the final date as desired by the user, by emitting
dateEntered() and dateChanged(), to match the other edit methods.

The documentation clarifies what I think was the intent of the 3
signals, and the unittest checks that the signals are emitted
accordingly.

BUG: 364200

Test Plan: Unittest passes; korganizer use case is fixed.

Reviewers: cfeck, dvratil, mlaurent

Reviewed By: mlaurent

Subscribers: mlaurent, anthonyfieroni, Frameworks, KDE PIM

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D8908

Details

Committed
dfaureJan 24 2018, 10:36 AM
Reviewer
mlaurent
Differential Revision
D8908: KDateComboBox: fix dateChanged() not emitted after typing a date
Parents
R236:01305e14e840: GIT_SILENT Upgrade KF5 version to 5.43.0.
Branches
Unknown
Tags
Unknown