Temperature Object Improvements

Authored by rizzitello on Nov 18 2018, 3:20 PM.

Description

Temperature Object Improvements

Summary:

  • Initialize our temp variables.
  • Current Temps require a .
  • Use Static Consts
  • Use R"(....)" to reduce need to handle special chars in regex.

Reduces the chance of a return containing T: or B: at the end of a word such as "PRINT JOB:1" being treated as the current temperature.

Reviewers: patrickelectric, laysrodrigues, tcanabrava

Reviewed By: patrickelectric, tcanabrava

Subscribers: Atelier: AtCore

Tags: Atelier: AtCore

Differential Revision: https://phabricator.kde.org/D16976

Details

Committed
rizzitelloNov 23 2018, 2:22 PM
Reviewer
patrickelectric
Differential Revision
D16976: Temperature Object Improvements
Parents
R232:78af3524dc0c: Use R"()"
R232:f715615fd30c: Fix typos in header
Branches
Unknown
Tags
Unknown

Merged Changes

CommitAuthorDetailsCommitted
78af3524dc0cD16976rizzitello
Use R"()" 
Nov 22 2018
d390b8b02419D16976rizzitello
All Currents Temps must have a . to avoid Possible False reading of returned… 
Nov 22 2018
6ece8e9aee61D16976rizzitello
Use const for our static regexs 
Nov 22 2018
1efc5def0c78D16976rizzitello
Initilize our temps 
Nov 22 2018