Fix PrivateActionToolButton behaviour with showText vs IconOnly
ClosedPublic

Authored by ahiemstra on Feb 27 2020, 12:51 PM.

Details

Summary

PrivateActionToolButton behaves slightly different when setting
showText to false versus setting display to IconOnly. This is
because the implicitWidth binding does not check the display
property. This fixes that to make sure both showText: false
and display: IconOnly return the implicitHeight, making the
button square in both cases.

Test Plan

Kirigami Gallery still works correctly.

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahiemstra created this revision.Feb 27 2020, 12:51 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptFeb 27 2020, 12:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Feb 27 2020, 12:51 PM
mart accepted this revision.Mar 2 2020, 11:31 AM
This revision is now accepted and ready to land.Mar 2 2020, 11:31 AM
This revision was automatically updated to reflect the committed changes.