Some fixes and simpifying startup settings.

Authored by Alexander Bikadorov <alex.bikadorov@kdemail.net> on Nov 13 2016, 5:28 PM.

Description

Some fixes and simpifying startup settings.

Summary:
Replaced custom slots for editing key bindings and shortcuts with default slots from KXmlGui

Set status bar visibility more reliable

Cleaning and fixing save/restore of startup settings. WIP

  • maximize switch for window state not needed and buggy
  • saveMainWindowSettings() saved but never read (wrong config group)
  • no danger of initializing default statusbar. Custom one is always set in constructor
  • most config options should be independent from "UI save settings"

Cleaning and fixing save/restore of startup settings: Updated settings dialog to reflect changes

Cleaning and fixing save/restore of startup settings: Save UI components on shutdown by default

Test Plan:

  • tested save/restore of window position/size in multi-monitor setup
  • tested "start to tray" option
  • tested "save position" option
  • tested with old config file
  • tested with no config file (clean start)

Reviewers: Krusader, martinkostolny

Reviewed By: Krusader, martinkostolny

Subscribers: martinkostolny

Differential Revision: https://phabricator.kde.org/D3353

Details

Committed
Alexander Bikadorov <alex.bikadorov@kdemail.net>Nov 16 2016, 3:06 PM
Reviewer
Krusader
Differential Revision
D3353: Some fixes and simpifying startup settings.
Parents
R167:6c623f1d507c: Some fixes and simpifying startup settings.
R167:99b564a8d426: Replace quickgit (decommissioned) links with cgit
Branches
Unknown
Tags
Unknown
Alexander Bikadorov <alex.bikadorov@kdemail.net> committed R167:2a6103ef5aaa: Some fixes and simpifying startup settings. (authored by Alexander Bikadorov <alex.bikadorov@kdemail.net>).Nov 16 2016, 3:06 PM

Merged Changes

CommitAuthorDetailsCommitted
6c623f1d507cD3353Alexander Bikadorov
Some fixes and simpifying startup settings. 
Nov 13 2016
4f69e377387fD3353Alexander Bikadorov
Cleaning and fixing save/restore of startup settings: Updated settings dialog… 
Nov 13 2016
b110bdb8a848D3353Alexander Bikadorov
Cleaning and fixing save/restore of startup settings. WIP 
Nov 13 2016
7cf47419b105D3353Alexander Bikadorov
Set status bar visibility more reliable 
Nov 13 2016
5dc463b425afD3353Alexander Bikadorov
Replaced custom slots for editing key bindings and shortcuts with default slots… 
Nov 13 2016