Some fixes and simpifying startup settings.
ClosedPublic

Authored by abika on Nov 13 2016, 5:52 PM.

Details

Summary

Replaced custom slots for editing key bindings and shortcuts with default slots from KXmlGui

Set status bar visibility more reliable

Cleaning and fixing save/restore of startup settings. WIP

  • maximize switch for window state not needed and buggy
  • saveMainWindowSettings() saved but never read (wrong config group)
  • no danger of initializing default statusbar. Custom one is always set in constructor
  • most config options should be independent from "UI save settings"

Cleaning and fixing save/restore of startup settings: Updated settings dialog to reflect changes

Cleaning and fixing save/restore of startup settings: Save UI components on shutdown by default

Test Plan
  • tested save/restore of window position/size in multi-monitor setup
  • tested "start to tray" option
  • tested "save position" option
  • tested with old config file
  • tested with no config file (clean start)

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abika updated this revision to Diff 8122.Nov 13 2016, 5:52 PM
abika retitled this revision from to Some fixes and simpifying startup settings..
abika updated this object.
abika edited the test plan for this revision. (Show Details)
abika added a reviewer: Krusader.
martinkostolny accepted this revision.Nov 14 2016, 10:35 PM
martinkostolny added a reviewer: martinkostolny.
martinkostolny added a subscriber: martinkostolny.

Works well, thanks for this Alex!

This revision is now accepted and ready to land.Nov 14 2016, 10:35 PM
This revision was automatically updated to reflect the committed changes.