Call QSqlQuery::finish() on all SELECT queries when done
2b6b63c248e4
Actions

Authored by dvratil on Dec 1 2018, 4:54 PM.

Description

Call QSqlQuery::finish() on all SELECT queries when done

It's what documentation says should be done, and once Qt is fixed it
will also cause the QSqlQuery to free the underlying DBMS' results,
so that keeping the query around in the caches won't cause them to
use insane amount of memory, if the last query happened to return a
lot of results.

(cherry picked from commit 089ee6959fcdbe7d94ce0227c3348f1ecc70053d)

Details

Committed

knauss

Aug 28 2019, 4:50 PM

Parents

R165:46d5d3fe22f8: ItemSync: skip handling remote items if local changes failed

Branches

Unknown

Tags

Unknown

knauss committed R165:2b6b63c248e4: Call QSqlQuery::finish() on all SELECT queries when done (authored by dvratil).Aug 28 2019, 4:50 PM

Changes (21)

				Path	Packages
	M			src/server/handler/colmove.cpp
	M			src/server/handler/fetch.cpp
	M			src/server/handler/fetchhelper.cpp
	M			src/server/handler/list.cpp
	M			src/server/handler/searchhelper.cpp
	M			src/server/handler/searchresult.cpp
	M			src/server/handler/status.cpp
	M			src/server/handler/tagappend.cpp
	M			src/server/handler/tagfetchhelper.cpp
	M			src/server/handlerhelper.cpp
	M			src/server/notificationmanager.cpp
	M			src/server/notificationsubscriber.cpp
	M			src/server/storage/collectionstatistics.cpp
	M			src/server/storage/countquerybuilder.h
	M			src/server/storage/datastore.cpp
	M			src/server/storage/dbinitializer.cpp
	M			src/server/storage/dbintrospector_impl.cpp
	M			src/server/storage/dbupdater.cpp
	M			src/server/storage/entities-source.xsl
	M			src/server/storage/itemretriever.cpp
	M			src/server/storagejanitor.cpp

Call QSqlQuery::finish() on all SELECT queries when done2b6b63c248e4Actions

Description

Details

Changes (21)

R165:2b6b63c248e4

src/server/handler/colmove.cpp

src/server/handler/fetch.cpp

src/server/handler/fetchhelper.cpp

src/server/handler/list.cpp

src/server/handler/searchhelper.cpp

src/server/handler/searchresult.cpp

src/server/handler/status.cpp

src/server/handler/tagappend.cpp

src/server/handler/tagfetchhelper.cpp

src/server/handlerhelper.cpp

src/server/notificationmanager.cpp

src/server/notificationsubscriber.cpp

src/server/storage/collectionstatistics.cpp

src/server/storage/countquerybuilder.h

src/server/storage/datastore.cpp

src/server/storage/dbinitializer.cpp

src/server/storage/dbintrospector_impl.cpp

src/server/storage/dbupdater.cpp

src/server/storage/entities-source.xsl

src/server/storage/itemretriever.cpp

src/server/storagejanitor.cpp

Call QSqlQuery::finish() on all SELECT queries when done
2b6b63c248e4
Actions