Keep QIcon::fromTheme in main thread

Authored by davidedmundson on May 16 2017, 8:03 PM.

Description

Keep QIcon::fromTheme in main thread

Summary:
QIcon::fromTheme is not thread safe, we can't have it done in the future
watcher.
We can solve this by returning null in the watcher, and doing fromTheme
in the main thread
when the watcher finishes if we don't have an icon.

Test Plan: Current unit tests still pass

Reviewers: Plasma, graesslin

Reviewed By: Plasma, graesslin

Subscribers: graesslin, plasma-devel, Frameworks

Tags: Frameworks, Plasma

Differential Revision: https://phabricator.kde.org/D5889

Details

Committed
davidedmundsonMay 16 2017, 8:03 PM
Reviewer
Plasma
Differential Revision
D5889: Keep QIcon::fromTheme in main thread
Parents
R127:c4caf02a9d4b: Remove pid changedSignal in Client::PlasmaWindow
Branches
Unknown
Tags
Unknown