Switch to Q_ASSERT
7a3722b4f5a3
Actions

Authored by zzag on Aug 31 2019, 2:28 PM.

Description

Switch to Q_ASSERT

Summary:
Switch to Q_ASSERT in order to make code a bit more consistent. We have
places where both assert and Q_ASSERT are used next to each other. Also,
distributions like Ubuntu don't strip away assert(), let's hope that
things are a bit different with Q_ASSERT.

Test Plan: Compiles.

Reviewers: KWin, davidedmundson

Reviewed By: KWin, davidedmundson

Subscribers: romangg, davidedmundson, kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D23605

Details

Committed

zzag	Aug 31 2019, 5:07 PM

Reviewer

KWin

Differential Revision

D23605: Switch to Q_ASSERT

Parents

R108:9102e41e71ce: Traverse the stacking order backwards when switching between windows

Branches

Unknown

Tags

Unknown

zzag committed R108:7a3722b4f5a3: Switch to Q_ASSERT (authored by zzag).Aug 31 2019, 5:07 PM

Changes (30)

				Path	Packages
	M			abstract_client.cpp
	M			activation.cpp
	M			client.cpp
	M			composite.cpp
	M			deleted.cpp
	M			effects.cpp
	M			effects/lookingglass/lookingglass.cpp
	M			effects/presentwindows/presentwindows.cpp
	M			geometry.cpp
	M			group.cpp
	M			kcmkwin/kwinrules/ruleslist.cpp
	M			kcmkwin/kwinrules/ruleswidget.cpp
	M			layers.cpp
	M			libkwineffects/kwineffects.cpp
	M			libkwineffects/kwineffects.h
	M			libkwineffects/kwinglutils.cpp
	M			manage.cpp
	M			placement.cpp
	M			platformsupport/scenes/opengl/abstract_egl_backend.cpp
	M			plugins/platforms/hwcomposer/hwcomposer_backend.cpp
	M			plugins/platforms/x11/standalone/glxbackend.cpp
	M			plugins/platforms/x11/standalone/overlaywindow_x11.cpp
	M			plugins/scenes/opengl/scene_opengl.cpp
	M			scene.cpp
	M			tabbox/tabbox.cpp
	M			toplevel.cpp
	M			toplevel.h
	M			useractions.cpp
	M			utils.cpp
	M			workspace.cpp

Switch to Q_ASSERT7a3722b4f5a3Actions

Description

Details

Changes (30)

R108:7a3722b4f5a3

abstract_client.cpp

activation.cpp

client.cpp

composite.cpp

deleted.cpp

effects.cpp

effects/lookingglass/lookingglass.cpp

effects/presentwindows/presentwindows.cpp

geometry.cpp

group.cpp

kcmkwin/kwinrules/ruleslist.cpp

kcmkwin/kwinrules/ruleswidget.cpp

layers.cpp

libkwineffects/kwineffects.cpp

libkwineffects/kwineffects.h

libkwineffects/kwinglutils.cpp

manage.cpp

placement.cpp

platformsupport/scenes/opengl/abstract_egl_backend.cpp

plugins/platforms/hwcomposer/hwcomposer_backend.cpp

plugins/platforms/x11/standalone/glxbackend.cpp

plugins/platforms/x11/standalone/overlaywindow_x11.cpp

plugins/scenes/opengl/scene_opengl.cpp

scene.cpp

tabbox/tabbox.cpp

toplevel.cpp

toplevel.h

useractions.cpp

utils.cpp

workspace.cpp

Switch to Q_ASSERT
7a3722b4f5a3
Actions