Switch to Q_ASSERT
ClosedPublic

Authored by zzag on Aug 31 2019, 2:50 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:7a3722b4f5a3: Switch to Q_ASSERT
Summary

Switch to Q_ASSERT in order to make code a bit more consistent. We have
places where both assert and Q_ASSERT are used next to each other. Also,
distributions like Ubuntu don't strip away assert(), let's hope that
things are a bit different with Q_ASSERT.

Test Plan

Compiles.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Aug 31 2019, 2:50 PM
Restricted Application added a project: KWin. · View Herald TranscriptAug 31 2019, 2:50 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Aug 31 2019, 2:50 PM

From my side it's ok to go in. @davidedmundson any objections against cleaning house?

davidedmundson accepted this revision.Aug 31 2019, 4:32 PM
davidedmundson added inline comments.
libkwineffects/kwineffects.cpp
938

heh, if we're going to spend time porting these, we may as well have gone to

if (kwinLoggingCategory.isEnabled) and used the modern runtime version

This revision is now accepted and ready to land.Aug 31 2019, 4:32 PM
zzag edited the summary of this revision. (Show Details)Aug 31 2019, 4:42 PM
This revision was automatically updated to reflect the committed changes.