Diffusion KWin 1a13015d2d1d

Possible fix for KDecoration crash in systemsettings

Authored by davidedmundson on Dec 14 2019, 3:08 PM.

Description

Possible fix for KDecoration crash in systemsettings

Summary:
I could never reproduce the crash, but we know from gdb that it's from
the decorationSettings object

We are setting the same QObject instance as a context property in
multiple contexts at once. This is already slightly odd especially from the POV of
Qt's internal property cache.

Given we want one object to be exposed to all contexts, we can expose it
to the parent context only once and achieve the same result in a simpler
way.

BUG: 411166

Test Plan:
Verified opening and closing system settings still worked for me.
I could never reproduce the original crash.

Reviewers: KWin, ngraham

Reviewed By: ngraham

Subscribers: ngraham, apol, kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D25913

Details