Provide a tooltip for the main action
ClosedPublic

Authored by apol on Jan 18 2018, 4:28 PM.

Details

Summary

This way there's a chance to see the action text without clicking it.

Test Plan

Manual testing

Diff Detail

Repository
R169 Kirigami
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Jan 18 2018, 4:28 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptJan 18 2018, 4:28 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Jan 18 2018, 4:28 PM
apol added a comment.Jan 18 2018, 4:29 PM

With tooltip

broulik added inline comments.
src/controls/private/ActionButton.qml
115 ↗(On Diff #25601)

Unfortunately there's no non-widgets API to get it but Qt uses 700 ms as SH_ToolTip_WakeUpDelay

apol added inline comments.Jan 19 2018, 12:39 AM
src/controls/private/ActionButton.qml
115 ↗(On Diff #25601)

We can create a new Kirigami.Units.toolTipDelay

mart added a comment.Jan 19 2018, 1:41 PM

in general, +1, tough there is something more to do here.
it already shown a notification on press and hold with the text, which should be ported to qqc2 tooltips instead of both things on top of each other.
also, should depend from Settings.isMobile: when false, it should appear on mouse over with the usual delay. when true, it should appear on press and hold, and disappear spontaneously after some delay.
ideally, all 3 buttons should support this.

mart added inline comments.Jan 19 2018, 1:43 PM
src/controls/private/ActionButton.qml
115 ↗(On Diff #25601)

+1, and the desktop style could use the value provided by qwidgets (while for the other ones is fine a sensible-looking hardcoded value)

apol updated this revision to Diff 25653.Jan 19 2018, 6:41 PM

Make it work for the other actions as well

apol updated this revision to Diff 25655.Jan 19 2018, 6:46 PM

No tooltip on mobile

mart accepted this revision.Jan 22 2018, 2:23 PM
This revision is now accepted and ready to land.Jan 22 2018, 2:23 PM
This revision was automatically updated to reflect the committed changes.