Notify document when async item is rendered
ClosedPublic
Actions

Authored by piggz on Jan 16 2018, 10:23 PM.

Details

Reviewers

staniek

Commits

Summary

async items like web and map do not notify the document when an item is rendered

Test Plan

Open report with web view and see renders appear as they become available

Repository

R14 KReport

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

piggz requested review of this revision.Jan 16 2018, 10:23 PM

Good job!
First comments, have not tested yet.

src/renderer/KReportAsyncItemManager_p.h
55	Not needed since m_curPage->document() can be used.
56	I hope it's safe to keep this raw pointer (wrt OROPage lifetime)?

This revision now requires changes to proceed.Jan 16 2018, 10:36 PM

It works for me! So one potential fix remains.

This revision was not accepted when it landed; it landed in state Needs Revision.Jan 19 2018, 10:19 PM

This revision was automatically updated to reflect the committed changes.

piggz marked 2 inline comments as done.Jan 19 2018, 10:30 PM

Note to ourselves: forgot to include it in 3.1 beta so it goes to the next minor version.

			Path	Packages
M			src/renderer/KReportAsyncItemManager_p.h (5 lines)
M			src/renderer/KReportAsyncItemManager_p.cpp (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	25510	f931a73		Jan 16 2018, 10:23 PM	★	★
Diff 2	25660	462857c	R14:df4177c0accf4c76368b830e3b5bf0f97fd77769	Jan 19 2018, 9:47 PM	★	★