Communicate code style changes wrt spaces near brackets

Authored by sanjibanb on Feb 19 2016, 9:44 PM.



Update CODING file to reflect that spaces near brackets are not to be used anymore, instead kdelibs style guide is followed for any new code.

Diff Detail

R34 Marble
Lint Skipped
Unit Tests Skipped
sanjibanb updated this revision to Diff 2401.Feb 19 2016, 9:44 PM
sanjibanb retitled this revision from to Communicate code style changes wrt spaces near brackets.
sanjibanb updated this object.
sanjibanb edited the test plan for this revision. (Show Details)
sanjibanb added reviewers: nienhueser, rahn.
sanjibanb set the repository for this revision to R34 Marble.
sanjibanb added a project: Marble.
sanjibanb abandoned this revision.Feb 20 2016, 9:44 AM
nienhueser added inline comments.Feb 20 2016, 7:41 PM

I think we need to get rid of the whole section in this case, because the preamble says "Due to historic reasons, the coding style of Marble has one exception to the kdelibs style. That exception is that we use the Qt way of using parenthesis, with a space inside both opening and closing parenthesis. For example" which is wrong now. So I'd remove this section 'Spaces and Parenthesis' entirely.

Makes sense. I am doing the above changes. I also think that in the 'Exceptions' section, "a couple of exceptions" should be changed to "an exception" in that case imho, right?

sanjibanb updated this revision to Diff 2405.Feb 20 2016, 8:09 PM
sanjibanb changed the visibility from "All Users" to "Public (No Login Required)".
sanjibanb marked an inline comment as done.Feb 21 2016, 6:22 PM

Pushed patch with the changes mentioned in the inline comments added above.

nienhueser accepted this revision.Feb 28 2016, 9:39 AM
nienhueser edited edge metadata.

Ok, fine. Please close this review request then.

This revision is now accepted and ready to land.Feb 28 2016, 9:39 AM
sanjibanb closed this revision.Mar 3 2016, 6:50 AM