Differential D9784

[ConfigModule] Re-use QML context and engine if any
ClosedPublic
Actions

Authored by broulik on Jan 10 2018, 10:28 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R296:84a370ce2c3a: [ConfigModule] Re-use QML context and engine if any
Summary

In case the ConfigModule is created within a QML context, re-use it and its engine instead of creating a shared QML object that might use a different engine.

CCBUG: 388766

Test Plan

Needs a followup patch in Plasma to set the context

Diff Detail

Repository
R296 KDeclarative
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jan 10 2018, 10:28 AM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptJan 10 2018, 10:28 AM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 10 2018, 10:28 AM
mart accepted this revision.Jan 12 2018, 3:36 PM
This revision is now accepted and ready to land.Jan 12 2018, 3:36 PM

Revision Contents
Changeset List

PathPackages
Msrc/quickaddons/configmodule.cpp (18 lines)

Diff 25066

View Options

src/quickaddons/configmodule.cpp

Loading...