Differential D9783

Performance: Reuse the global icon loader
ClosedPublic
Actions

Authored by mwolff on Jan 10 2018, 10:05 AM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R32:94ed49aceac4: Performance: Reuse the global icon loader
Summary

I just found a noticeable GUI hang when showing a problem widget
for a missing include path. There, the profiler pointed me at
KIconLoader which was reconstructed whenever we query for the icon
representing the severity of a problem.

By reusing the global icon loader, we can get the information from
the cache which is significantly faster.

Diff Detail

Repository
R32 KDevelop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
mwolff created this revision.Jan 10 2018, 10:05 AM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 10 2018, 10:05 AM
mwolff requested review of this revision.Jan 10 2018, 10:05 AM
kfunk accepted this revision.EditedJan 10 2018, 10:13 AM
kfunk added a subscriber: kfunk.

Whoops. My code. Sorry.

This revision is now accepted and ready to land.Jan 10 2018, 10:13 AM
Closed by commit R32:94ed49aceac4: Performance: Reuse the global icon loader (authored by mwolff). · Explain WhyJan 10 2018, 10:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25064

View Options

kdevplatform/language/duchain/navigation/problemnavigationcontext.cpp

Loading...