Differential D9755

Move contents into fullRepresentation
ClosedPublic
Actions

Authored by broulik on Jan 9 2018, 11:15 AM.

Details

Reviewers

drosca

Group Reviewers

Plasma

Commits

R994:be9b6f6afacf: Move contents into fullRepresentation
R115:be9b6f6afacf: Move contents into fullRepresentation

Summary

Keeps it from loading all the models and items on startup.

Test Plan

Seems to make a bit of a difference on plasmashell startup.
Verified that volume keys (up/down/mute) and wheeling the icon still work even if the full rep had not been loaded yet (e.g. right after startup without opening the applet)
Verified that the content is created the first time I open the applet

Diff Detail

Repository

R115 Plasma Audio Volume Applet

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik created this revision.Jan 9 2018, 11:15 AM

Restricted Application added a project: Plasma. · View Herald TranscriptJan 9 2018, 11:15 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Jan 9 2018, 11:15 AM

Actually I have a patch D4140 that depends on all models being initialized immediately.
But yeah, given the fact that I haven't landed it yet and there are no bug reports about incorrect volume notifications I guess this can go in.

drosca accepted this revision.Jan 10 2018, 2:32 PM

This revision is now accepted and ready to land.Jan 10 2018, 2:32 PM

Closed by commit R115:be9b6f6afacf: Move contents into fullRepresentation (authored by broulik). · Explain WhyJan 10 2018, 5:19 PM

This revision was automatically updated to reflect the committed changes.

drosca mentioned this in D4140: Rework playing of volume feedback.May 7 2018, 2:35 PM