Differential D9744

Further extend the argument hint code completion test coverage
ClosedPublic
Actions

Authored by mwolff on Jan 8 2018, 10:31 PM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R32:67b8f6c20cdc: Further extend the argument hint code completion test coverage
Summary

Also check whether we find matching declarations, and add test
code that uses namespaces. This uncovers a deficit in libclang,
namely clang_getCompletionParent on the overload candidate completion
strings does not return any valid string. Without a valid parent
we cannot find the namespaced declarations and thus fail there...

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mwolff created this revision.Jan 8 2018, 10:31 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 8 2018, 10:31 PM
mwolff requested review of this revision.Jan 8 2018, 10:31 PM
kfunk accepted this revision.Jan 9 2018, 7:31 AM
kfunk added a subscriber: kfunk.
kfunk added inline comments.
plugins/clang/tests/test_codecompletion.cpp
1139

Uhm, I thought there's a generic char *QTest::toString(const QVector<T>) helper. But indeed there isn't.

This revision is now accepted and ready to land.Jan 9 2018, 7:31 AM
mwolff added inline comments.Jan 9 2018, 9:54 AM
plugins/clang/tests/test_codecompletion.cpp
1139

I also thought that would be the case - odd, isn't it?

Closed by commit R32:67b8f6c20cdc: Further extend the argument hint code completion test coverage (authored by mwolff). · Explain WhyJan 9 2018, 9:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24989

View Options

plugins/clang/tests/test_codecompletion.cpp

Loading...