Fix for xembedsniproxy crash due to NULL returned from xcb_image_get()

Authored by maciejsitarz on Jan 8 2018, 1:57 PM.



In my environment (Fedora 27, plasma-workspace-5.11.4-1.fc27.x86_64) xembedsniproxy crashes.
This is caused by NULL being returned by xcb_image_get().

This should fix or at least mitigate the problems from bugs:

Diff Detail

R120 Plasma Workspace
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
maciejsitarz created this revision.Jan 8 2018, 1:57 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 8 2018, 1:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
maciejsitarz requested review of this revision.Jan 8 2018, 1:57 PM
broulik added a subscriber: broulik.Jan 8 2018, 2:20 PM

Thanks for your patch! I'll let David have a look at it who maintains xembedsniproxy.


Just do

if (image) {

The indentation seems a little off, we use four spaces for indentation.

davidedmundson accepted this revision.Jan 8 2018, 2:27 PM

Do you have commit access.

This revision is now accepted and ready to land.Jan 8 2018, 2:27 PM
maciejsitarz marked an inline comment as done.Jan 8 2018, 2:57 PM

@davidedmundson I don't have commit access
(I'm not sure if you were asking me or @broulik)


Fixed the 'if' and indentation in the newly uploaded diff

This revision was automatically updated to reflect the committed changes.