Differential D9732

Fix for xembedsniproxy crash due to NULL returned from xcb_image_get()
ClosedPublic
Actions

Authored by maciejsitarz on Jan 8 2018, 1:57 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:12e3568042fb: Fix for xembedsniproxy crash due to NULL returned from xcb_image_get()
R120:e2b7c395ecdb: Fix for xembedsniproxy crash due to NULL returned from xcb_image_get()
Summary

In my environment (Fedora 27, plasma-workspace-5.11.4-1.fc27.x86_64) xembedsniproxy crashes.
This is caused by NULL being returned by xcb_image_get().

This should fix or at least mitigate the problems from bugs:
https://bugs.kde.org/show_bug.cgi?id=355463
https://bugs.kde.org/show_bug.cgi?id=359664
https://bugzilla.redhat.com/show_bug.cgi?id=1497829

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
maciejsitarz created this revision.Jan 8 2018, 1:57 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 8 2018, 1:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
maciejsitarz requested review of this revision.Jan 8 2018, 1:57 PM
broulik added a subscriber: broulik.Jan 8 2018, 2:20 PM

Thanks for your patch! I'll let David have a look at it who maintains xembedsniproxy.

xembed-sni-proxy/sniproxy.cpp
292

Just do

if (image) {

The indentation seems a little off, we use four spaces for indentation.

davidedmundson accepted this revision.Jan 8 2018, 2:27 PM

Thanks.
Do you have commit access.

This revision is now accepted and ready to land.Jan 8 2018, 2:27 PM
maciejsitarz marked an inline comment as done.Jan 8 2018, 2:57 PM

@davidedmundson I don't have commit access
(I'm not sure if you were asking me or @broulik)

xembed-sni-proxy/sniproxy.cpp
292

Fixed the 'if' and indentation in the newly uploaded diff

Closed by commit R120:e2b7c395ecdb: Fix for xembedsniproxy crash due to NULL returned from xcb_image_get() (authored by maciejsitarz, committed by davidedmundson). · Explain WhyJan 8 2018, 3:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mxembed-sni-proxy/sniproxy.cpp (8 lines)

Diff 24944

View Options

xembed-sni-proxy/sniproxy.cpp

Loading...