| lesliezhai | |
| rkflx |
KUrlRequester::setAcceptMode() got introduced in KIO 5.33.0, but k3b specifies 5.21.0 as minimum version.
Modify the KUrlRequester's fileDialog() directly when using an older version to fix the compilation.
This is intended for the Applications/17.12 branch, I consider it a bug that k3b fails to compile with KIO < 5.33 even though it states 5.21.0 as minimum.
Compiles successfully now with KDE Frameworks 5.26.0 and 5.32.0, and also still with 5.41.0.
Resulting application still opens a "Save Mode" requester for selecting the temp folder, even if built with KDE Frameworks < 5.33.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Thanks, LGTM when reading the code and testing with different KIO versions. I'd say wait a day or two for any objections from @lesliezhai, and then commit to the Applications/18.04 branch.
BTW, what's the situation for KDE Applications 18.08 and Leap 42.3? Is support for KF 5.32 still nice to have, or is a higher version available anyway due to more and more apps bumping versions? Maybe we could simply change to 5.33 for the master branch?
(I'm also asking because we'll likely have to require 5.38 in Gwenview soon.)
In general on Phabricator you cannot see unsubmitted comments from others, AFAIK. Likely it was a glitch relating to a comment of yours?
In principle, this is not really a problem for us, as we (openSUSE) only build the latest KDE Applications against the latest Frameworks, also for Leap 42.3.
(and the applications included in Leap 42.3 will not get upgraded anyway)
k3b in particular is also provided by the Packman 3rd party repo though, they offer the latest versions of k3b and kdenlive for released openSUSE distributions like Leap 42.3. (mainly for historic reasons I think, until a few months ago MP3 support couldn't be included in the official packages e.g., but that's no longer the case)
So, raising the minimum version to >=5.33.0 will break their build for Leap 42.3 (which comes with KDE Frameworks 5.32.0).
Other than that, the successor Leap 15.0 is going to be released in about 4 weeks, and this will of course come with the latest Frameworks (likely 5.45.0).
Leap 42.3 will then go out of support about half a year later...
So, if you'd ask me, I'd prefer to keep the current minimum KF5 version for 18.08 and wait till 18.12 to raise it. ;-)
If you'd decide to do it now, it will not be a big problem for us either though, just that Packman won't be able to provide the latest version for Leap 42.3 any more (I'd probably patch it though)
(I'm also asking because we'll likely have to require 5.38 in Gwenview soon.)
This won't affect us at all.
In general on Phabricator you cannot see unsubmitted comments from others, AFAIK. Likely it was a glitch relating to a comment of yours?
No idea. It disappeared completely meanwhile anyway...
Hi Wolfgang,
Sorry for my late response!
I haven't received review notification from my email address lesliezhai@llvm.org.cn
But thanks for your patch!
Regards,
Leslie Zhai