Differential D9703

Allow applications using KActivities to not crash even if no dbus server is around
ClosedPublic
Actions

Authored by cullmann on Jan 6 2018, 9:44 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Frameworks
KActivities
Commits
R6:90858efa8c60: avoid crash in kactivities if no dbus connection is available
Summary

Allow applications using KActivities to not crash even if no dbus server is around.

e.g. Kate on macOS does immediately crash on opening any file ATM, as the calls have no checks if dbus is alive at all.
With these checks, all is fine, thought no activities handling occurs, naturally.

An other solution would be to just skip compiling kactivies on macOS, but on the other side I think guarding against the case of no dbus connection is around doesn't hurt.

Test Plan

without patch: crash on file open in e.g. kate

with path: file open works in kate

Diff Detail

Repository
R6 KActivities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cullmann created this revision.Jan 6 2018, 9:44 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 6 2018, 9:44 PM
cullmann requested review of this revision.Jan 6 2018, 9:44 PM
davidedmundson accepted this revision.Jan 6 2018, 11:05 PM
This revision is now accepted and ready to land.Jan 6 2018, 11:05 PM
Closed by commit R6:90858efa8c60: avoid crash in kactivities if no dbus connection is available (authored by cullmann). · Explain WhyJan 6 2018, 11:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/manager_p.cpp (5 lines)

Diff 24856

View Options

src/lib/manager_p.cpp

Loading...