Differential D9700

Added 'Comment' option to metadata config-dialog
ClosedPublic
Actions

Authored by michaelh on Jan 6 2018, 2:42 PM.

Details

Reviewers
ngraham
Group Reviewers
Dolphin
Commits
R824:caf155114b3b: Added 'Comment' option to metadata config-dialog
Summary

BUG: 365620

DISCLAIMER:
I have no idea how this code really works. It was just a guess.

Test Plan

compile baloo-widgets, run dolphin

Diff Detail

Repository
R824 Baloo Widgets
Branch
comment
Lint
No Linters Available
Unit
No Unit Test Coverage
michaelh requested review of this revision.Jan 6 2018, 2:42 PM
michaelh created this revision.
michaelh retitled this revision from Added 'Comment' option to GUI to Added 'Comment' option to metadata config-dialog.Jan 6 2018, 2:52 PM
michaelh edited the summary of this revision. (Show Details)
michaelh edited the test plan for this revision. (Show Details)
michaelh added a reviewer: Dolphin.
michaelh added a subscriber: vhanda.
michaelh removed a subscriber: akrutzler.Jan 6 2018, 4:36 PM
ngraham edited the summary of this revision. (Show Details)Jan 6 2018, 5:17 PM
ngraham added a subscriber: ngraham.

Does it actually work to turn off the Comment field now?

michaelh added a comment.Jan 6 2018, 11:35 PM

Yes. As the screenshot depicts. Checkbox clear => No Comment field.
And you of course you can also turn it on. Not shown but tested.

ngraham accepted this revision.Jan 6 2018, 11:45 PM

Works great! It'll be great to have this annoying issue fixed. Thanks so much for the patch.

FWIW, would you be interested in submitting another patch to add a proper .arcconfig file for baloo-widgets?

This revision is now accepted and ready to land.Jan 6 2018, 11:45 PM
ngraham closed this revision.Jan 6 2018, 11:48 PM

Revision Contents
Changeset List

PathPackages
Msrc/filemetadataconfigwidget.cpp (4 lines)

Diff 24837

View Options

src/filemetadataconfigwidget.cpp

Loading...