Change Details

To be executed after running the packaging script. 1. CMake configure Krita + build 3. Run packaging script 3. In an empty directory, do the following: ``` lang=batch cmake -DREMOVE_DEBUG=ON -DOUTPUT_FILEPATH="%cd%\krita-setup-test.exe"-DKRITA_PACKAGE_ROOT="absolute_path_to_krita_package_output_directory" -P path_to_install_directory\MakeinstallerNsis.cmake ``` Set `REMOVE_DEBUG` to `ON` deletes the debug symbols so they won't be included in the installer. TODO: Download NSIS directly in this script instead of using the installed one.

To be executed after running the packaging script. 1. CMake configure Krita + build 3. Run packaging script 3. In an empty directory, do the following: ``` lang=batch cmake -DREMOVE_DEBUG=ON -DOUTPUT_FILEPATH="%cd%\krita-setup-test.exe"-DKRITA_PACKAGE_ROOT="absolute_path_to_krita_package_output_directory" -P path_to_install_directory\MakeinstallerNsis.cmake ``` Set `REMOVE_DEBUG` to `ON` deletes the debug symbols so they won't be included in the installer. The script downloads its copy of NSIS. On the binary factory it probably means adding this after running the packaging script: ``` lang=batch mkdir installer pushd installer cmake -DREMOVE_DEBUG=ON -DOUTPUT_FILEPATH="%cd%\krita-%version_string%-x64-setup.exe"-DKRITA_PACKAGE_ROOT="%cd%\..\krita-%version_string%-x64" -P C:\Packaging\KritaWS\krita-install\MakeinstallerNsis.cmake if errorlevel 1 exit /b 1 signtool sign %SIGNTOOL_SIGN_FLAGS% krita-%version_string%-x64-setup.exe if errorlevel 1 exit /b 1 popd ``` assuming the package name is "krita-%version_string%-x64" where "%version_string%" is replaced with the release version number and "x64" is replaced to "x86" the 32-bit build. (You can test it with the nightly build, but if you do please add "DO-NOT-USE" to the output installer filename and rename the file extension to something that is not ".exe", e.g. ".dat")

To be executed after running the packaging script. 1. CMake configure Krita + build 3. Run packaging script 3. In an empty directory, do the following: ``` lang=batch cmake -DREMOVE_DEBUG=ON -DOUTPUT_FILEPATH="%cd%\krita-setup-test.exe"-DKRITA_PACKAGE_ROOT="absolute_path_to_krita_package_output_directory" -P path_to_install_directory\MakeinstallerNsis.cmake ``` Set `REMOVE_DEBUG` to `ON` deletes the debug symbols so they won't be included in the installer. The script downloads its copy of NSIS. TODO: Download NSIS directly in this script instead of using the installed one.On the binary factory it probably means adding this after running the packaging script: ``` lang=batch mkdir installer pushd installer cmake -DREMOVE_DEBUG=ON -DOUTPUT_FILEPATH="%cd%\krita-%version_string%-x64-setup.exe"-DKRITA_PACKAGE_ROOT="%cd%\..\krita-%version_string%-x64" -P C:\Packaging\KritaWS\krita-install\MakeinstallerNsis.cmake if errorlevel 1 exit /b 1 signtool sign %SIGNTOOL_SIGN_FLAGS% krita-%version_string%-x64-setup.exe if errorlevel 1 exit /b 1 popd ``` assuming the package name is "krita-%version_string%-x64" where "%version_string%" is replaced with the release version number and "x64" is replaced to "x86" the 32-bit build. (You can test it with the nightly build, but if you do please add "DO-NOT-USE" to the output installer filename and rename the file extension to something that is not ".exe", e.g. ".dat")